Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(linter): error rule config in media_has_caption #1864

Merged
merged 3 commits into from
Dec 31, 2023

Conversation

msdlisper
Copy link
Contributor

@msdlisper msdlisper commented Dec 31, 2023

fix error rule config

serde_json::json!({
    "audio": [ "Audio" ],
    "video": [ "Video" ],
    "track": [ "Track" ],
})

to

serde_json::json!([{
    "audio": [ "Audio" ],
    "video": [ "Video" ],
    "track": [ "Track" ],
}])

based on the eslint docs, if a rule configuration is passed, it has to look like <RULE NAME>: [<SEVERITY>, config]

@github-actions github-actions bot added the A-linter Area - Linter label Dec 31, 2023
Copy link
Contributor

@camc314 camc314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@camc314 camc314 merged commit b2a62dd into oxc-project:main Dec 31, 2023
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-linter Area - Linter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants