fix(ci): update benchmark workflow for cargo-codspeed v4.3.0#18359
Merged
fix(ci): update benchmark workflow for cargo-codspeed v4.3.0#18359
Conversation
Member
Author
Merge activity
|
Boshen
force-pushed
the
fix-benchmark-codspeed
branch
from
7796826 to
fc894c9
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request updates the benchmark CI workflow to support cargo-codspeed v4.3.0 and includes a fix for TypeScript quoted property formatting in classes.
Changes:
- Updated benchmark workflow directory path from
target/codspeed/simulation/totarget/codspeed/analysis/ - Updated CodSpeedHQ/action from v4.7.0 to v4.8.2
- Fixed formatter to preserve quotes on TypeScript class properties under
--strictPropertyInitialization
Reviewed changes
Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| .github/workflows/benchmark.yml | Updated directory paths and action version to support cargo-codspeed v4.3.0 |
| crates/oxc_formatter/src/utils/object.rs | Added TypeScript-specific logic to preserve quoted property names in classes |
| tasks/prettier_conformance/snapshots/prettier.ts.snap.md | Updated snapshot showing improved TypeScript compatibility (583→584 tests passing) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
cargo-codspeed v4.3.0 (CodSpeedHQ/codspeed-rust#159) changed internal build mode mapping so `MeasurementMode::Simulation` now maps to `BuildMode::Analysis`, which changed the expected directory from `target/codspeed/simulation/` to `target/codspeed/analysis/`. Also updates CodSpeedHQ/action to v4.8.2. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Boshen
force-pushed
the
fix-benchmark-codspeed
branch
from
fc894c9 to
f5053cb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
target/codspeed/simulation/→target/codspeed/analysis/Root Cause
cargo-codspeed v4.3.0 (CodSpeedHQ/codspeed-rust#159) changed internal build mode mapping so
MeasurementMode::Simulationnow maps toBuildMode::Analysis, which changed the expected directory fromtarget/codspeed/simulation/totarget/codspeed/analysis/.Test plan
🤖 Generated with Claude Code