Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(semantic): improve check super implementation, reduce access nodes #1827

Conversation

Dunqing
Copy link
Member

@Dunqing Dunqing commented Dec 26, 2023

This improves the performance at which we can check that super is in a non-class.

Copy link

codspeed-hq bot commented Dec 26, 2023

CodSpeed Performance Report

Merging #1827 will not alter performance

Comparing 12-26-feat_semantic_improve_check_super_implementation_reduce_access_nodes (0577adc) with main (f7b7f0a)

Summary

✅ 14 untouched benchmarks

@Dunqing Dunqing marked this pull request as draft December 26, 2023 11:04
@Dunqing Dunqing force-pushed the 12-26-feat_semantic_improve_check_super_implementation_reduce_access_nodes branch 5 times, most recently from 8f12d98 to 9858f4d Compare December 27, 2023 04:45
@Dunqing Dunqing force-pushed the 12-26-feat_semantic_support_get_node_id_by_scope_id branch from 457da1e to 7251cc0 Compare December 27, 2023 04:57
@Dunqing Dunqing force-pushed the 12-26-feat_semantic_improve_check_super_implementation_reduce_access_nodes branch 3 times, most recently from d74a788 to 4aca01d Compare December 27, 2023 05:46
@Dunqing Dunqing marked this pull request as ready for review December 27, 2023 06:10
Copy link
Member

Boshen commented Dec 27, 2023

Merge activity

  • Dec 27, 9:24 AM: @Boshen started a stack merge that includes this pull request via Graphite.
  • Dec 27, 9:31 AM: Graphite rebased this pull request as part of a merge.
  • Dec 27, 9:36 AM: @Boshen merged this pull request with Graphite.

@Boshen Boshen force-pushed the 12-26-feat_semantic_support_get_node_id_by_scope_id branch from 7251cc0 to 9dd6aa0 Compare December 27, 2023 14:24
Base automatically changed from 12-26-feat_semantic_support_get_node_id_by_scope_id to main December 27, 2023 14:30
@Boshen Boshen force-pushed the 12-26-feat_semantic_improve_check_super_implementation_reduce_access_nodes branch from 4aca01d to 0577adc Compare December 27, 2023 14:30
@Boshen Boshen merged commit b9bdf36 into main Dec 27, 2023
17 checks passed
@Boshen Boshen deleted the 12-26-feat_semantic_improve_check_super_implementation_reduce_access_nodes branch December 27, 2023 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-semantic Area - Semantic
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants