Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(linter): eslint-plugin-unicorn no-null(style) #1705

Merged
merged 5 commits into from
Dec 17, 2023
Merged

feat(linter): eslint-plugin-unicorn no-null(style) #1705

merged 5 commits into from
Dec 17, 2023

Conversation

Ken-HH24
Copy link
Contributor

Try to implement no-null for #684 .

@github-actions github-actions bot added the A-linter Area - Linter label Dec 17, 2023
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Dec 17, 2023

CodSpeed Performance Report

Merging #1705 will improve performances by 5.22%

Comparing Ken-HH24:feat/no-null (3648d0f) with main (a96e428)

Summary

⚡ 1 improvements
✅ 19 untouched benchmarks

Benchmarks breakdown

Benchmark main Ken-HH24:feat/no-null Change
⚡ semantic[vue.js] 80.4 ms 76.4 ms +5.22%

@camc314 camc314 mentioned this pull request Dec 17, 2023
Open
camc314
camc314 approved these changes Dec 17, 2023
View reviewed changes
Copy link
Contributor

@camc314 camc314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@camc314 camc314 merged commit 774a257 into oxc-project:main Dec 17, 2023
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@camc314 camc314 camc314 approved these changes

Assignees
No one assigned
Labels
A-linter Area - Linter
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Ken-HH24 @camc314