Skip to content

feat(linter): implement react/no-deprecated rule #16782

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
FMP1783 wants to merge 5 commits into
base: main
Choose a base branch
from
Open

feat(linter): implement react/no-deprecated rule #16782

FMP1783 wants to merge 5 commits into from
+1,085 −1

Conversation

@FMP1783
Copy link
Contributor

@FMP1783 FMP1783 commented Dec 12, 2025

Summary

  • Implement react/no-deprecated rule that warns about deprecated React APIs
  • Detects deprecated methods on React, ReactDOM, ReactDOMServer objects
  • Detects deprecated lifecycle methods in class components
  • Detects deprecated imports from react, react-dom, react-addons-perf
  • Covers 48/55 (87%) of ESLint test cases

Test cases not covered

  • Version-based tests (requires settings support for react.version)
  • Pragma-based tests (requires settings support for react.pragma)

Part of #1022

Test plan

  • All existing tests pass
  • Snapshot tests added and verified
  • just ready passes

@FMP1783
feat(linter): implement react/no-deprecated rule
6b6ba18 
Detects usage of deprecated React APIs and suggests alternatives.

Detected patterns:
- React.* deprecated methods (renderComponent, render, createClass, etc.)
- ReactDOM.* deprecated methods (render, hydrate, unmountComponentAtNode)
- ReactDOMServer.* deprecated methods (renderToNodeStream)
- React.PropTypes, React.DOM
- React.addons.* (TestUtils, classSet)
- Deprecated lifecycle methods in React components
- Deprecated imports from 'react' and 'react-addons-perf'
- this.transferPropsTo()

Part of oxc-project#1022
@github-actions github-actions bot added A-linter Area - Linter C-enhancement Category - New feature or request labels Dec 12, 2025
@FMP1783
Merge branch 'main' into feat/react-no-deprecated
7311a15 
Signed-off-by: FMP1783 <79391918+FMP1783@users.noreply.github.com>
@FMP1783 FMP1783 marked this pull request as ready for review December 12, 2025 18:14
@FMP1783 FMP1783 requested a review from camc314 as a code owner December 12, 2025 18:14
@codspeed-hq
Copy link

codspeed-hq bot commented Dec 12, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #16782 will not alter performance

Comparing FMP1783:feat/react-no-deprecated (f975c20) with main (fbcb49a)1

Summary

✅ 4 untouched
⏩ 41 skipped2

Footnotes

  1. No successful run was found on main (2124d03) during the generation of this report, so fbcb49a was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

  2. 41 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

@github-actions github-actions bot added the A-cli Area - CLI label Dec 12, 2025
@camc314 camc314 self-assigned this Dec 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@camc314 camc314 Awaiting requested review from camc314 camc314 is a code owner

Assignees

@camc314 camc314

Labels

A-cli Area - CLI A-linter Area - Linter C-enhancement Category - New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@FMP1783 @camc314