feat(oxfmt): .editorconfig support

.editorconfig

@@ -11,3 +11,6 @@ indent_size = 4
 
 [*.{js,mjs,cjs,jsx,ts,tsx,json,yml}]
 indent_size = 2
+
+[*.{md}]
+indent_size = 2

Cargo.toml

@@ -180,6 +180,7 @@ convert_case = "0.10.0" # Case conversion
 cow-utils = "0.1.3" # Copy-on-write utilities
 criterion2 = { version = "3.0.2", default-features = false } # Benchmarking
 dragonbox_ecma = "0.0.5" # Fast float formatting
+editorconfig-parser = "0.0.2" # .editorconfig parser
 encoding_rs = "0.8.35" # Character encoding
 encoding_rs_io = "0.1.7" # Encoding I/O
 env_logger = { version = "0.11.8", default-features = false } # Logging implementation

apps/oxfmt/Cargo.toml

@@ -36,6 +36,7 @@ oxc_span = { workspace = true }
 
 bpaf = { workspace = true, features = ["autocomplete", "bright-color", "derive"] }
 cow-utils = { workspace = true }
+editorconfig-parser = { workspace = true }
 ignore = { workspace = true, features = ["simd-accel"] }
 json-strip-comments = { workspace = true }
 miette = { workspace = true }

apps/oxfmt/src/cli/format.rs

@@ -18,7 +18,7 @@ use super::{
     service::{FormatService, SuccessResult},
     walk::Walk,
 };
-use crate::core::{SourceFormatter, utils};
+use crate::core::{SourceFormatter, editorconfig::find_root_editorconfig, utils};
 
 #[derive(Debug)]
 pub struct FormatRunner {
@@ -129,6 +129,8 @@ impl FormatRunner {
             }
         };
 
+        let editorconfig = find_root_editorconfig(&cwd);
+
         // Get the receiver for streaming entries
         let rx_entry = walker.stream_entries();
         // Collect format results (changed paths or unchanged count)
@@ -143,7 +145,7 @@ impl FormatRunner {
         }
 
         // Create `SourceFormatter` instance
-        let source_formatter = SourceFormatter::new(num_of_threads, format_options);
+        let source_formatter = SourceFormatter::new(num_of_threads, format_options, editorconfig);
         #[cfg(feature = "napi")]
         let source_formatter = source_formatter
             .with_external_formatter(self.external_formatter, oxfmt_options.is_sort_package_json);

apps/oxfmt/src/core/editorconfig.rs

@@ -0,0 +1,21 @@
+use std::path::Path;
+
+use editorconfig_parser::{EditorConfig, EditorConfigProperties};
+use oxc_formatter::FormatOptions;
+
+use crate::core::utils::read_to_string;
+
+/// Find root `.editorconfig`.
+/// <https://github.com/prettier/prettier/blob/v3.7/src/config/editorconfig/index.js>
+pub fn find_root_editorconfig(cwd: &Path) -> Option<EditorConfig> {
+    let root =
+        cwd.ancestors().find(|path| path.join(".git").exists() || path.join(".hg").exists())?;
+    let source = read_to_string(&root.join(".editorconfig")).ok()?;
+    Some(EditorConfig::parse(&source))
+}
+
+pub fn merge_editorconfig_and_format_options(
+    properties: EditorConfigProperties,
+    options: &FormatOptions,
+) -> FormatOptions {
+}

apps/oxfmt/src/core/format.rs

@@ -8,7 +8,9 @@ use oxc_formatter::{FormatOptions, Formatter, enable_jsx_source_type, get_parse_
 use oxc_parser::Parser;
 use oxc_span::SourceType;
 
-use super::FormatFileStrategy;
+use editorconfig_parser::EditorConfig;
+
+use super::{FormatFileStrategy, editorconfig::merge_editorconfig_and_format_options};
 
 pub enum FormatResult {
     Success { is_changed: bool, code: String },
@@ -18,17 +20,23 @@ pub enum FormatResult {
 pub struct SourceFormatter {
     allocator_pool: AllocatorPool,
     format_options: FormatOptions,
+    editorconfig: Option<EditorConfig>,
     #[cfg(feature = "napi")]
     pub is_sort_package_json: bool,
     #[cfg(feature = "napi")]
     external_formatter: Option<super::ExternalFormatter>,
 }
 
 impl SourceFormatter {
-    pub fn new(num_of_threads: usize, format_options: FormatOptions) -> Self {
+    pub fn new(
+        num_of_threads: usize,
+        format_options: FormatOptions,
+        editorconfig: Option<EditorConfig>,
+    ) -> Self {
         Self {
             allocator_pool: AllocatorPool::new(num_of_threads),
             format_options,
+            editorconfig,
             #[cfg(feature = "napi")]
             is_sort_package_json: false,
             #[cfg(feature = "napi")]
@@ -93,11 +101,18 @@ impl SourceFormatter {
             return Err(ret.errors.into_iter().next().unwrap());
         }
 
-        let base_formatter = Formatter::new(&allocator, self.format_options.clone());
+        let format_options = if let Some(editorconfig) = &self.editorconfig {
+            let properties = editorconfig.resolve(path);
+            // TODO: create default options, override by editorconfig, then override by config options.
+            merge_editorconfig_and_format_options(properties)
+        } else {
+            self.format_options.clone()
+        };
+        let base_formatter = Formatter::new(&allocator, format_options.clone());
 
         #[cfg(feature = "napi")]
         let formatted = {
-            if self.format_options.embedded_language_formatting.is_off() {
+            if format_options.embedded_language_formatting.is_off() {
                 base_formatter.format(&ret.program)
             } else {
                 let embedded_formatter = self

apps/oxfmt/src/core/mod.rs

@@ -1,3 +1,4 @@
+pub mod editorconfig;
 mod format;
 mod support;
 pub mod utils;

justfile

@@ -183,7 +183,7 @@ oxfmt:
 
 # watch oxfmt, e.g. `just watch-oxfmt test.js`
 watch-oxfmt *args='':
-  just watch 'cargo run -p oxfmt -- {{args}}'
+  just watch 'cargo run -p oxfmt --no-default-features -- -c ./oxfmtrc.jsonc {{args}}'
 
 # Build oxfmt in release build
 oxfmt-node: