chore(infra): use oxfmt for all files, remove dprint #16599
Conversation
github-actions
bot
added
the
C-cleanup
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
There was a problem hiding this comment.
Pull request overview
This PR migrates the project's formatting infrastructure from dprint to oxfmt, completing the transition to using oxfmt for all supported file types (JavaScript, TypeScript, JSON, YAML, Markdown, CSS, HTML, etc.). TOML formatting is acknowledged as missing but deferred until oxfmt plugin support is available.
Key Changes:
- Removed dprint as a project dependency and deleted its configuration
- Updated oxfmtrc.jsonc with additional ignore patterns for CHANGELOG.md, snapshot files, and pnpm-lock.yaml
- Updated all GitHub workflows to remove dprint installation and caching steps
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| oxfmtrc.jsonc | Added ignore patterns for CHANGELOG.md, *.snap.md files, and pnpm-lock.yaml |
| justfile | Removed dprint from init command and fmt recipe; updated documentation comments |
| dprint.json | Deleted entire dprint configuration file |
| AGENTS.md | Removed dprint from the list of pre-installed tools |
| .github/workflows/update_submodules.yml | Removed dprint from tools list |
| .github/workflows/dprint.yml | Deleted entire workflow for dprint plugin caching |
| .github/workflows/copilot-setup-steps.yml | Removed dprint tool installation and cache restoration steps |
| .github/workflows/autofix.yml | Removed dprint tool installation and cache restoration steps |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| "napi/{parser,transform,minify,playground}/**/browser.js", | ||
| "npm/runtime/src", | ||
| "npm/oxc-types/types.d.ts", | ||
| "pnpm-lock.yaml", |
There was a problem hiding this comment.
The ignore patterns are missing some entries that were previously excluded by dprint.json. The following files should also be added to the ignore list as they are generated or configuration files that should not be formatted:
pnpm-workspace.yaml(configuration file, should not be auto-formatted)npm/*/package.json(generated bynpm/oxlint/scripts/generate-packages.jsand similar scripts)npm/{oxlint,oxfmt}/configuration_schema.json(generated from Rust code in test files)
These files were explicitly excluded in the removed dprint.json configuration.
| "pnpm-lock.yaml", | |
| "pnpm-lock.yaml", | |
| "pnpm-workspace.yaml", | |
| "npm/*/package.json", | |
| "npm/{oxlint,oxfmt}/configuration_schema.json", |
Boshen
force-pushed
the
12-08-chore_infra_use_oxfmt_for_all_files_remove_dprint
branch
from
0723a18 to
42ffa36
Compare
github-actions
bot
added
A-linter
closes #16602 Toml formatting is missing but there's only a few toml files, can wait for oxfmt plugins.
Boshen
force-pushed
the
12-08-chore_infra_use_oxfmt_for_all_files_remove_dprint
branch
from
42ffa36 to
987b9f2
Compare
Toml formatting is missing but there's only a few toml files, can wait
for oxfmt plugins.