-
-
Notifications
You must be signed in to change notification settings - Fork 723
feat(parser): improve error message for missing closing tokens that may be followed by a rest element #15444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
CodSpeed Performance ReportMerging #15444 will not alter performanceComparing Summary
|
8c7b3e5 to
bfb3f76
Compare
Merge activity
|
…ay be followed by a rest element (#15444) Improves error message for imbalanced tokens that allows rest elements. **Before** ``` × Expected `,` but found `Identifier` ╭─[typescript/tests/cases/compiler/restParamModifier.ts:2:27] 1 │ class C { 2 │ constructor(...public rest: string[]) {} · ──┬─ · ╰── `,` expected 3 │ } ╰──── ``` **After** ``` × Expected `,` or `)` but found `Identifier` ╭─[typescript/tests/cases/compiler/restParamModifier.ts:2:27] 1 │ class C { 2 │ constructor(...public rest: string[]) {} · ┬ ──┬─ · │ ╰── `,` or `)` expected · ╰── Opened here 3 │ } ╰──── ```
bfb3f76 to
e1704a4
Compare

Improves error message for imbalanced tokens that allows rest elements.
Before
After