Skip to content

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Nov 5, 2025

Address just wraps a usize, so make it #[repr(transparent)]. This may improve perf in some cases (or maybe not, but still it's good practice).

@github-actions github-actions bot added the C-performance Category - Solution not expected to change functional behavior, only performance label Nov 5, 2025
Copy link
Member Author

overlookmotel commented Nov 5, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@codspeed-hq
Copy link

codspeed-hq bot commented Nov 5, 2025

CodSpeed Performance Report

Merging #15312 will not alter performance

Comparing 09-17-perf_allocator_address_add_repr_transparent_to_address_ (011ce16) with 09-17-docs_allocator_address_improve_docs_for_address_from_ptr_ (f2b6b90)

Summary

✅ 37 untouched

@graphite-app graphite-app bot added the 0-merge Merge with Graphite Merge Queue label Nov 5, 2025
@graphite-app
Copy link
Contributor

graphite-app bot commented Nov 5, 2025

Merge activity

)

`Address` just wraps a `usize`, so make it `#[repr(transparent)]`. This may improve perf in some cases (or maybe not, but still it's good practice).
@graphite-app graphite-app bot force-pushed the 09-17-docs_allocator_address_improve_docs_for_address_from_ptr_ branch from f2b6b90 to ed0e023 Compare November 5, 2025 11:31
@graphite-app graphite-app bot force-pushed the 09-17-perf_allocator_address_add_repr_transparent_to_address_ branch from 011ce16 to bfd17fd Compare November 5, 2025 11:32
Base automatically changed from 09-17-docs_allocator_address_improve_docs_for_address_from_ptr_ to main November 5, 2025 11:38
@graphite-app graphite-app bot merged commit bfd17fd into main Nov 5, 2025
22 checks passed
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Nov 5, 2025
@graphite-app graphite-app bot deleted the 09-17-perf_allocator_address_add_repr_transparent_to_address_ branch November 5, 2025 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C-performance Category - Solution not expected to change functional behavior, only performance

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants