-
-
Notifications
You must be signed in to change notification settings - Fork 721
docs(linter): Add config option docs for 7 rules. #15209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…-generic-constructors rule.
…ctive-tabindex rule. This required changing the way this is implemented slightly so we properly derive the default value, otherwise the JsonSchema derivation complained.
…sociated-control rule.
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds schema configuration support to multiple linter rules by implementing JSON schema serialization/deserialization. The changes enable proper configuration documentation and validation for these rules.
- Adds
Serialize,Deserialize, andJsonSchemaderives to configuration structs - Adds
#[serde(rename_all = "...")]attributes for consistent JSON key naming - Moves configuration option documentation from rule-level doc comments to field-level doc comments
- Adds
configparameter todeclare_oxc_lint!macro calls
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
consistent_generic_constructors.rs |
Adds schema support and field-level documentation for generic constructor preferences |
spec_only.rs |
Adds schema support for Promise method allowlist configuration |
no_noninteractive_tabindex.rs |
Adds schema support and refactors Default implementation to config struct |
media_has_caption.rs |
Adds schema support for media element name configuration |
label_has_associated_control.rs |
Adds schema support for label and control configuration |
prefer_lowercase_title/mod.rs |
Reorganizes documentation by moving option descriptions to field-level comments |
no_self_assign.rs |
Moves props option documentation from rule-level to field-level |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
crates/oxc_linter/src/rules/typescript/consistent_generic_constructors.rs
Outdated
Show resolved
Hide resolved
…tructors.rs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Connor Shea <connor.james.shea@gmail.com>
CodSpeed Performance ReportMerging #15209 will not alter performanceComparing Summary
Footnotes
|
Part of #14743.
For
jsx-a11y/no-noninteractive-tabindex, this required changing the way this is implemented slightly so we properly derive the default value, otherwise the JsonSchema derivation complained.Generated docs: