-
-
Notifications
You must be signed in to change notification settings - Fork 722
test(editor): wait longer for "detects diagnostics on run" fixture #15156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(editor): wait longer for "detects diagnostics on run" fixture #15156
Conversation
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR improves test reliability and assertion precision in the VSCode extension's E2E diagnostic tests. The changes address potential timing issues and make test assertions more specific.
- Increased sleep duration in the 'detects diagnostics on run' test to reduce flakiness
- Replaced loose assertion with strict equality check for diagnostic count validation
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Merging without a review because it's only tests and the stack of #14472 will grow :) |
Merge activity
|
…15156) Another task is flaky `changing oxc.typeAware will revalidate the tsgolint diagnostics `, but not sure if this is related with oxc-project/tsgolint#349
7c63944 to
1c4444c
Compare

Another task is flaky
changing oxc.typeAware will revalidate the tsgolint diagnostics, but not sure if this is related with oxc-project/tsgolint#349