Skip to content

Conversation

@Sysix
Copy link
Member

@Sysix Sysix commented Oct 30, 2025

Another task is flaky changing oxc.typeAware will revalidate the tsgolint diagnostics , but not sure if this is related with oxc-project/tsgolint#349

@github-actions github-actions bot added A-editor Area - Editor and Language Server C-test Category - Testing. Code is missing test cases, or a PR is adding them labels Oct 30, 2025
Copy link
Member Author

Sysix commented Oct 30, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@Sysix Sysix marked this pull request as ready for review October 30, 2025 18:31
@Sysix Sysix requested a review from camc314 as a code owner October 30, 2025 18:31
Copilot AI review requested due to automatic review settings October 30, 2025 18:31
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR improves test reliability and assertion precision in the VSCode extension's E2E diagnostic tests. The changes address potential timing issues and make test assertions more specific.

  • Increased sleep duration in the 'detects diagnostics on run' test to reduce flakiness
  • Replaced loose assertion with strict equality check for diagnostic count validation

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@Sysix
Copy link
Member Author

Sysix commented Oct 30, 2025

Merging without a review because it's only tests and the stack of #14472 will grow :)

@Sysix Sysix added the 0-merge Merge with Graphite Merge Queue label Oct 30, 2025
Copy link
Member Author

Sysix commented Oct 30, 2025

Merge activity

…15156)

Another task is flaky `changing oxc.typeAware will revalidate the tsgolint diagnostics `, but not sure if this is related with oxc-project/tsgolint#349
@graphite-app graphite-app bot force-pushed the 10-30-test_editor_wait_longer_for_detects_diagnostics_on_run_fixture branch from 7c63944 to 1c4444c Compare October 30, 2025 20:15
@graphite-app graphite-app bot merged commit 1c4444c into main Oct 30, 2025
19 checks passed
@graphite-app graphite-app bot deleted the 10-30-test_editor_wait_longer_for_detects_diagnostics_on_run_fixture branch October 30, 2025 20:19
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Oct 30, 2025
@Boshen Boshen mentioned this pull request Nov 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-editor Area - Editor and Language Server C-test Category - Testing. Code is missing test cases, or a PR is adding them

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants