Skip to content

Conversation

@connorshea
Copy link
Collaborator

Part of #14743.

Generated docs:

## Configuration

This rule accepts a configuration object with the following properties:

### allowLoop

type: `boolean`

default: `false`

If set to `true`, this rule ignores labels which are sticking to loop statements.
Examples of **correct** code with this option set to `true`:
\```js
label:
while (true) {
break label;
}
\```


### allowSwitch

type: `boolean`

default: `false`

If set to `true`, this rule ignores labels which are sticking to switch statements.
Examples of **correct** code with this option set to `true`:
\```js
label:
switch (a) {
case 0:
break label;
}
\```

Copilot AI review requested due to automatic review settings October 30, 2025 04:36
@connorshea connorshea requested a review from camc314 as a code owner October 30, 2025 04:36
@graphite-app
Copy link
Contributor

graphite-app bot commented Oct 30, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@github-actions github-actions bot added A-linter Area - Linter C-docs Category - Documentation. Related to user-facing or internal documentation labels Oct 30, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request refactors the no_labels rule configuration by moving option documentation from the rule's main documentation to the struct fields themselves. The main changes are:

  • Moved allowLoop and allowSwitch configuration documentation from the macro-level doc comments to field-level doc comments with examples
  • Added JsonSchema derive and #[serde(...)] attribute to support JSON Schema generation
  • Added config = NoLabels to the lint declaration macro

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codspeed-hq
Copy link

codspeed-hq bot commented Oct 30, 2025

CodSpeed Performance Report

Merging #15112 will not alter performance

Comparing connorshea:no-labels-docs (8c531c5) with main (3fbb307)1

Summary

✅ 4 untouched
⏩ 33 skipped2

Footnotes

  1. No successful run was found on main (2ca7387) during the generation of this report, so 3fbb307 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

  2. 33 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@camc314 camc314 merged commit 5e6b62e into oxc-project:main Oct 30, 2025
27 checks passed
@Boshen Boshen mentioned this pull request Nov 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-linter Area - Linter C-docs Category - Documentation. Related to user-facing or internal documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants