Skip to content

Conversation

@wagenet
Copy link
Contributor

@wagenet wagenet commented Oct 28, 2025

This resolves some situations where JS plugins would be incorrectly marked as not available. This especially affected namespaced plugins.

@graphite-app
Copy link
Contributor

graphite-app bot commented Oct 28, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@github-actions github-actions bot added the A-linter Area - Linter label Oct 28, 2025
@codspeed-hq
Copy link

codspeed-hq bot commented Oct 28, 2025

CodSpeed Performance Report

Merging #15010 will not alter performance

Comparing wagenet:improve-plugin-name-normalization (383815f) with main (5eaaa8e)1

Summary

✅ 4 untouched
⏩ 33 skipped2

Footnotes

  1. No successful run was found on main (597340e) during the generation of this report, so 5eaaa8e was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

  2. 33 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@wagenet wagenet force-pushed the improve-plugin-name-normalization branch from bb4c3f5 to 83985ce Compare October 28, 2025 00:57
@wagenet wagenet marked this pull request as ready for review October 28, 2025 15:09
@wagenet wagenet requested a review from camc314 as a code owner October 28, 2025 15:09
Copilot AI review requested due to automatic review settings October 28, 2025 15:09
@wagenet wagenet changed the title Fix plugin name normalization Fix JS plugin name normalization Oct 28, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes plugin name normalization to correctly handle various ESLint plugin naming conventions, particularly for namespaced plugins. The fix prevents JS plugins from being incorrectly marked as unavailable.

Key changes:

  • Introduces a normalize_plugin_name() function that strips common ESLint plugin prefixes/suffixes
  • Applies normalization consistently across plugin registration and rule parsing
  • Adds comprehensive test coverage for the normalization logic

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
crates/oxc_linter/src/lib.rs Exports the normalize_plugin_name function for public use
crates/oxc_linter/src/config/plugins.rs Implements the normalize_plugin_name() function and integrates it into LintPlugins::try_from()
crates/oxc_linter/src/config/rules.rs Applies normalization in unalias_plugin_name() and adds tests for rule parsing with plugin prefixes
crates/oxc_linter/src/config/mod.rs Changes plugins module visibility from private to public
crates/oxc_linter/src/config/config_builder.rs Normalizes plugin names during external plugin registration

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@wagenet wagenet force-pushed the improve-plugin-name-normalization branch from 52ecb44 to 8242f29 Compare October 28, 2025 15:15
Copy link
Member

@Sysix Sysix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
I was wondering why i needed eslint-plugin-xyz/rule to enable it, but expected a eslint version like xyz/rule instead.

Thanks to you, I could check @stylistic plugin: #14862 (comment)

Sysix added a commit to Sysix/oxlint-jsplugin-checker that referenced this pull request Oct 28, 2025
@camc314 camc314 changed the title Fix JS plugin name normalization fix(linter): normalize JS plugin names Oct 29, 2025
@github-actions github-actions bot added the C-bug Category - Bug label Oct 29, 2025
@camc314 camc314 force-pushed the improve-plugin-name-normalization branch from f19102c to ab9e02d Compare October 29, 2025 09:59
Copy link
Contributor

@camc314 camc314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@camc314
Copy link
Contributor

camc314 commented Oct 29, 2025

the failing CI is unrelated to your change. It should be fixed via #15064

@camc314 camc314 force-pushed the improve-plugin-name-normalization branch from ab9e02d to 383815f Compare October 29, 2025 11:57
@camc314 camc314 merged commit ee68089 into oxc-project:main Oct 29, 2025
19 checks passed
camc314 added a commit that referenced this pull request Oct 30, 2025
## [1.25.0] - 2025-10-30

### 💥 BREAKING CHANGES

- 659fd37 linter: [**BREAKING**] `tsgolint`: request fixes when
necessary (#15048) (camchenry)

### 🚀 Features

- ed24d60 linter: Expose tsgolint program diagnostics (#15080) (camc314)
- 23660c9 linter: `tsgolint`: handle omitted fixes and suggestions
(#15047) (camchenry)
- f7bef73 linter/plugins: Scope manager API (#14890) (Arsh)
- 3e15cdd linter/strict-boolean-expression: Add rule (#14930) (camc314)
- bd74603 linter: Add support for vitest/valid-title rule (#12085)
(Tyler Earls)

### 🐛 Bug Fixes

- e41dee5 linter/consistent-type-definition: Skip comments when looking
for token (#14909) (camc314)
- 806f9ba linter: Search system PATH for tsgolint executable (#14861)
(magic-akari)
- ee68089 linter: Normalize JS plugin names (#15010) (Peter Wagenet)
- 597340e ast-tools: Use oxfmt to format generated code (#15064)
(camc314)
- 5eaaa8e linter: Prevent underflow in count_comment_lines for JSX files
(#15026) (ityuany)
- 88577a8 import/no-namespace: Remove dot special case (#15032) (Arsh)
- 55ee962 linter/vars-on-top: False positive with typescript declare
block (#14952) (Hamir Mahal)
- 2de9f39 linter/plugins: Fall back to package name if meta.name is
missing (#14938) (Peter Wagenet)
- 5ace84b linter/no-empty-object-type: Parse `"allowWithName"` as
regular expressions (#14943) (Arsh)
- 5a2832d editor: Stop client when delete .oxlintrc.json with
`oxc.requireConfig` (#14897) (Liang Mi)
- 3e29d23 linter: Use aliases when parsing cli rules (#14912) (Arsh)
- b94b6aa linter/explicit-module-boundary-types: False negative with
export default function (#14905) (camc314)
- 7060863 linter/no-standaline-expect: False positive with expect in
callback (#14902) (camc314)
- dc5a71b linter/no-accumulating-spread: False positive in nested
callbacks within reduce (#14898) (camc314)

### 🚜 Refactor

- 8d8d508 editor: Flatten `flags` options (#15006) (Sysix)
- b1e1531 language_server: Extract library interface from main.rs
(#15036) (Boshen)
- 5de99c2 formatter: Export unified way to get_parse_options (#15027)
(leaysgur)
- b55df7f language_server: Move sub option for `flags` to the root +
deprecate flags (#14933) (Sysix)

### 📚 Documentation

- e15c91c linter: Add configuration option docs for
eslint/init-declarations rule. (#15085) (Connor Shea)
- f4505bc linter: Add configuration option docs for eslint/id-length
rule. (#15083) (Connor Shea)
- dd4c9d2 linter: Add configuration option docs for eslint/getter-return
rule. (#15081) (Connor Shea)
- 008e67a linter: Add configuration option docs for
jest/no-large-snapshots rule. (#15079) (Connor Shea)
- 31daf79 linter: Add configuration option docs for import/no-commonjs
rule. (#15077) (Connor Shea)
- 9bf8ebe linter: Add configuration option docs for
jsdoc/check-tag-names rule. (#15076) (Connor Shea)
- 491ab5e linter: Add configuration option docs for jsdoc/no-defaults
rule. (#15074) (Connor Shea)
- 2602d7e linter: Add configuration option docs for jsdoc/empty-tags
rule. (#15072) (Connor Shea)
- c3a92e0 linter: Add configuration option docs for
oxc/no-rest-spread-properties rule. (#15070) (Connor Shea)
- c7c9213 linter: Add configuration option docs for
oxc/no-optional-chaining rule. (#15071) (Connor Shea)
- 47a616f linter: Add configuration option docs for
typescript/no-empty-object-type rule. (#14968) (Connor Shea)
- fcc1e25 linter: Add configuration option docs for
typescript/no-explicit-any rule. (#15051) (Connor Shea)
- 1b88934 linter: Add configuration option docs for
eslint/no-multi-assign rule. (#15052) (Connor Shea)
- 909d4b9 linter: Add configuration option docs for
eslint/no-unsafe-negation rule. (#15053) (Connor Shea)
- f60763b linter: Add configuration option docs for
eslint/no-useless-computed-key rule. (#15054) (Connor Shea)
- c8911d4 linter: Add configuration option docs for
eslint/no-unneeded-ternary rule. (#15056) (Connor Shea)
- 9fc6374 linter: Add configuration option docs for
eslint/no-misleading-character-class rule. (#15058) (Connor Shea)
- 7656e2b linter: Add configuration option docs for eslint/sort-imports
rule. (#15013) (Connor Shea)
- bb06039 linter: Add configuration option docs for
unicorn/no-instanceof-builtins rule. (#14999) (Connor Shea)
- a4af5ff linter: Add configuration option docs for
unicorn/no-typeof-undefined rule. (#15001) (Connor Shea)
- ac2ed39 linter: Add configuration option docs for
unicorn/numeric-separators-style rule. (#15002) (Connor Shea)
- 5ce3e33 linter: Add configuration option docs for
unicorn/prefer-object-from-entries rule. (#15003) (Connor Shea)
- 07aea72 linter: Add configuration option docs for eslint/sort-keys
rule. (#15014) (Connor Shea)
- 35b36e0 linter: Add configuration option docs for eslint/no-eval rule.
(#15015) (Connor Shea)
- d222b85 linter: Add configuration option docs for eslint/no-empty
rule. (#15017) (Connor Shea)
- 83bbc37 linter: Add configuration option docs for
eslint/no-extend-native rule. (#15018) (Connor Shea)
- aade2fe linter: Add configuration option docs for
eslint/no-extra-boolean-cast rule. (#15019) (Connor Shea)
- bae0c09 linter: Add configuration option docs for jsdoc/require-yields
rule. (#15024) (Connor Shea)
- 06c77b6 linter: Add configuration option docs for unicorn/prefer-at
rule. (#15023) (Connor Shea)
- 54b2cb4 linter: Add configuration option docs for
eslint/max-classes-per-file rule. (#15022) (Connor Shea)
- b5acda7 linter: Add configuration option docs for
typescript/explicit-module-boundary-types rule. (#15021) (Connor Shea)
- a0c6162 linter: Add configuration option docs for vue/max-props rule.
(#14966) (Connor Shea)
- 3ec59c0 linter: Add configuration option docs for
no-async-endpoint-handlers rule. (#14965) (Connor Shea)
- 7a275fd linter: Add configuration option docs for no-map-spread rule.
(#14964) (Connor Shea)
- 0002b7c linter: Add configuration option docs for no-barrel-file rule.
(#14963) (Connor Shea)
- fd4b7ab linter: Add configuration option docs for
unicorn/consistent-function-scoping rule. (#14969) (Connor Shea)
- aa339b3 linter: Add configuration option docs for eslint/no-void rule.
(#14970) (Connor Shea)
- af8bdae linter: Add configuration option docs for
import/no-anonymous-default-export rule. (#14971) (Connor Shea)
- 5a81953 linter: Add configuration option docs for jest/require-hook
rule. (#14972) (Connor Shea)
- 1be268d linter: Add configuration option docs for
jest/require-top-level-describe rule. (#14973) (Connor Shea)
- 860a58c linter: Add configuration option docs for jest/no-hooks rule.
(#14974) (Connor Shea)
- b69b586 linter: Add configuration option docs for jest/max-expects
rule. (#14975) (Connor Shea)
- 2e02fe0 linter: Add configuration option docs for
jest/no-deprecated-functions rule (#14976) (Connor Shea)
- cdc6c4f linter: Add configuration option docs for
unicorn/no-array-sort rule. (#14977) (Connor Shea)
- 40eb394 linter/no-unassigned-import-config: Add auto generated config
docs (#14918) (camc314)

### ⚡ Performance

- a9f68b2 linter: Move up rule retainment into initial collection to
reduce allocation size (#14822) (camchenry)
- b27c5b9 linter: Add codegen support for regex nodes (#14874)
(camchenry)

### 🧪 Testing

- bf898e5 linter: Increase stability of tsgolint test cases (#15063)
(camc314)
- 49da411 linter/no-standalone-expect: Fix tests (#14901) (camc314)

Co-authored-by: camc314 <18101008+camc314@users.noreply.github.com>
@overlookmotel overlookmotel added A-linter-plugins Area - Linter JS plugins and removed A-linter Area - Linter labels Nov 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-linter-plugins Area - Linter JS plugins C-bug Category - Bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants