Skip to content

Conversation

@Boshen
Copy link
Member

@Boshen Boshen commented Oct 27, 2025

  • Rename workflow: update_compat_table.yml → update_submodules.yml
  • Extract hardcoded SHAs in clone-parallel.sh into variables at the top
  • Expand workflow to automatically update all 6 submodules:
    • test262 (tc39/test262)
    • babel (babel/babel)
    • TypeScript (microsoft/TypeScript)
    • prettier (prettier/prettier)
    • acorn-test262 (oxc-project/acorn-test262)
    • node-compat-table (williamkapke/node-compat-table)
  • Workflow now fetches latest SHAs from all repos, compares with current, and updates clone-parallel.sh
  • Creates single PR with summary of all updated submodules

🤖 Generated with Claude Code

Copilot AI review requested due to automatic review settings October 27, 2025 11:54
@graphite-app
Copy link
Contributor

graphite-app bot commented Oct 27, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@Boshen Boshen marked this pull request as draft October 27, 2025 11:54
@github-actions github-actions bot added the C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior label Oct 27, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors the CI workflow to automate submodule updates across all 6 conformance test repositories instead of just the compat-table. The workflow now fetches the latest commit SHAs from test262, babel, TypeScript, prettier, acorn-test262, and node-compat-table, compares them with the current SHAs in clone-parallel.sh, and creates a single PR with all updates when changes are detected.

Key changes:

  • Replaced single-purpose update_compat_table.yml workflow with generalized update_submodules.yml workflow
  • Extracted hardcoded SHAs in clone-parallel.sh to variables at the top of the file for automated updates
  • Expanded automation to cover all 6 conformance test repositories

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

File Description
.github/workflows/update_submodules.yml New workflow that fetches latest SHAs for all 6 submodules, compares with current values, updates clone-parallel.sh, and creates a PR
.github/workflows/update_compat_table.yml Deleted old workflow that only handled compat-table updates
.github/scripts/clone-parallel.sh Extracted hardcoded SHAs to variables at the top of the file and updated clone_repo calls to use these variables

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@Boshen Boshen force-pushed the refactor/centralize-clone-script branch 6 times, most recently from 994d024 to 0e19a7e Compare October 27, 2025 12:17
@Boshen Boshen marked this pull request as ready for review October 27, 2025 12:18
@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Oct 27, 2025
Copy link
Member Author

Boshen commented Oct 27, 2025

Merge activity

  • Oct 27, 12:24 PM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Oct 27, 12:27 PM UTC: Boshen added this pull request to the Graphite merge queue.
  • Oct 27, 12:32 PM UTC: The Graphite merge queue couldn't merge this PR because it was in draft mode.
  • Oct 27, 12:38 PM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Oct 27, 12:43 PM UTC: Boshen added this pull request to the Graphite merge queue.
  • Oct 27, 12:49 PM UTC: Merged by the Graphite merge queue.

graphite-app bot pushed a commit that referenced this pull request Oct 27, 2025
…mance test repos (#14990)

- Rename workflow: update_compat_table.yml → update_submodules.yml
- Extract hardcoded SHAs in clone-parallel.sh into variables at the top
- Expand workflow to automatically update all 6 submodules:
  - test262 (tc39/test262)
  - babel (babel/babel)
  - TypeScript (microsoft/TypeScript)
  - prettier (prettier/prettier)
  - acorn-test262 (oxc-project/acorn-test262)
  - node-compat-table (williamkapke/node-compat-table)
- Workflow now fetches latest SHAs from all repos, compares with current, and updates clone-parallel.sh
- Creates single PR with summary of all updated submodules

🤖 Generated with [Claude Code](https://claude.com/claude-code)
@graphite-app graphite-app bot force-pushed the refactor/centralize-clone-script branch from 39df7b8 to 025a3d2 Compare October 27, 2025 12:28
@Boshen Boshen force-pushed the refactor/centralize-clone-script branch from 025a3d2 to 107337e Compare October 27, 2025 12:29
graphite-app bot pushed a commit that referenced this pull request Oct 27, 2025
…mance test repos (#14990)

- Rename workflow: update_compat_table.yml → update_submodules.yml
- Extract hardcoded SHAs in clone-parallel.sh into variables at the top
- Expand workflow to automatically update all 6 submodules:
  - test262 (tc39/test262)
  - babel (babel/babel)
  - TypeScript (microsoft/TypeScript)
  - prettier (prettier/prettier)
  - acorn-test262 (oxc-project/acorn-test262)
  - node-compat-table (williamkapke/node-compat-table)
- Workflow now fetches latest SHAs from all repos, compares with current, and updates clone-parallel.sh
- Creates single PR with summary of all updated submodules

🤖 Generated with [Claude Code](https://claude.com/claude-code)
@graphite-app graphite-app bot force-pushed the refactor/centralize-clone-script branch from 107337e to 314da88 Compare October 27, 2025 12:30
@Boshen Boshen marked this pull request as draft October 27, 2025 12:32
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Oct 27, 2025
@Boshen Boshen force-pushed the refactor/centralize-clone-script branch from 314da88 to 0953b10 Compare October 27, 2025 12:37
@Boshen Boshen marked this pull request as ready for review October 27, 2025 12:38
@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Oct 27, 2025
…mance test repos (#14990)

- Rename workflow: update_compat_table.yml → update_submodules.yml
- Extract hardcoded SHAs in clone-parallel.sh into variables at the top
- Expand workflow to automatically update all 6 submodules:
  - test262 (tc39/test262)
  - babel (babel/babel)
  - TypeScript (microsoft/TypeScript)
  - prettier (prettier/prettier)
  - acorn-test262 (oxc-project/acorn-test262)
  - node-compat-table (williamkapke/node-compat-table)
- Workflow now fetches latest SHAs from all repos, compares with current, and updates clone-parallel.sh
- Creates single PR with summary of all updated submodules

🤖 Generated with [Claude Code](https://claude.com/claude-code)
@graphite-app graphite-app bot force-pushed the refactor/centralize-clone-script branch from 0953b10 to 7bcc6b0 Compare October 27, 2025 12:44
@graphite-app graphite-app bot merged commit 7bcc6b0 into main Oct 27, 2025
20 checks passed
@graphite-app graphite-app bot deleted the refactor/centralize-clone-script branch October 27, 2025 12:49
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Oct 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants