-
-
Notifications
You must be signed in to change notification settings - Fork 723
refactor(ci): expand submodule update workflow to handle all 6 conformance test repos #14990
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR refactors the CI workflow to automate submodule updates across all 6 conformance test repositories instead of just the compat-table. The workflow now fetches the latest commit SHAs from test262, babel, TypeScript, prettier, acorn-test262, and node-compat-table, compares them with the current SHAs in clone-parallel.sh, and creates a single PR with all updates when changes are detected.
Key changes:
- Replaced single-purpose
update_compat_table.ymlworkflow with generalizedupdate_submodules.ymlworkflow - Extracted hardcoded SHAs in
clone-parallel.shto variables at the top of the file for automated updates - Expanded automation to cover all 6 conformance test repositories
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
.github/workflows/update_submodules.yml |
New workflow that fetches latest SHAs for all 6 submodules, compares with current values, updates clone-parallel.sh, and creates a PR |
.github/workflows/update_compat_table.yml |
Deleted old workflow that only handled compat-table updates |
.github/scripts/clone-parallel.sh |
Extracted hardcoded SHAs to variables at the top of the file and updated clone_repo calls to use these variables |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
994d024 to
0e19a7e
Compare
Merge activity
|
…mance test repos (#14990) - Rename workflow: update_compat_table.yml → update_submodules.yml - Extract hardcoded SHAs in clone-parallel.sh into variables at the top - Expand workflow to automatically update all 6 submodules: - test262 (tc39/test262) - babel (babel/babel) - TypeScript (microsoft/TypeScript) - prettier (prettier/prettier) - acorn-test262 (oxc-project/acorn-test262) - node-compat-table (williamkapke/node-compat-table) - Workflow now fetches latest SHAs from all repos, compares with current, and updates clone-parallel.sh - Creates single PR with summary of all updated submodules 🤖 Generated with [Claude Code](https://claude.com/claude-code)
39df7b8 to
025a3d2
Compare
025a3d2 to
107337e
Compare
…mance test repos (#14990) - Rename workflow: update_compat_table.yml → update_submodules.yml - Extract hardcoded SHAs in clone-parallel.sh into variables at the top - Expand workflow to automatically update all 6 submodules: - test262 (tc39/test262) - babel (babel/babel) - TypeScript (microsoft/TypeScript) - prettier (prettier/prettier) - acorn-test262 (oxc-project/acorn-test262) - node-compat-table (williamkapke/node-compat-table) - Workflow now fetches latest SHAs from all repos, compares with current, and updates clone-parallel.sh - Creates single PR with summary of all updated submodules 🤖 Generated with [Claude Code](https://claude.com/claude-code)
107337e to
314da88
Compare
314da88 to
0953b10
Compare
…mance test repos (#14990) - Rename workflow: update_compat_table.yml → update_submodules.yml - Extract hardcoded SHAs in clone-parallel.sh into variables at the top - Expand workflow to automatically update all 6 submodules: - test262 (tc39/test262) - babel (babel/babel) - TypeScript (microsoft/TypeScript) - prettier (prettier/prettier) - acorn-test262 (oxc-project/acorn-test262) - node-compat-table (williamkapke/node-compat-table) - Workflow now fetches latest SHAs from all repos, compares with current, and updates clone-parallel.sh - Creates single PR with summary of all updated submodules 🤖 Generated with [Claude Code](https://claude.com/claude-code)
0953b10 to
7bcc6b0
Compare
🤖 Generated with Claude Code