Skip to content

Conversation

@connorshea
Copy link
Collaborator

I can/should probably start batching these changes into larger PRs rather than opening one at a time.

Part of #14743.

Exported docs result:

## Configuration

This rule accepts a configuration object with the following properties:

### allowComputed

type: `boolean`

default: `false`

Whether to allow computed references to an imported namespace.

Copilot AI review requested due to automatic review settings October 20, 2025 05:50
@connorshea connorshea requested a review from camc314 as a code owner October 20, 2025 05:50
@graphite-app
Copy link
Contributor

graphite-app bot commented Oct 20, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@github-actions github-actions bot added A-linter Area - Linter C-docs Category - Documentation. Related to user-facing or internal documentation labels Oct 20, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds configuration documentation for the import/namespace linter rule by implementing the JsonSchema trait and documenting the allow_computed configuration option.

Key Changes:

  • Added JsonSchema derive macro and serde attributes to enable configuration schema generation
  • Documented the allow_computed field with a doc comment
  • Registered the configuration struct in the lint rule declaration

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link
Contributor

@camc314 camc314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank yoU!

@camc314 camc314 merged commit b1fb269 into oxc-project:main Oct 20, 2025
20 checks passed
@camc314 camc314 self-assigned this Oct 20, 2025
@codspeed-hq
Copy link

codspeed-hq bot commented Oct 20, 2025

CodSpeed Performance Report

Merging #14799 will not alter performance

Comparing connorshea:import-namespace-docs (fd0c02e) with main (d185aeb)

Summary

✅ 4 untouched
⏩ 33 skipped1

Footnotes

  1. 33 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-linter Area - Linter C-docs Category - Documentation. Related to user-facing or internal documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants