test(editor): reduce sleep time #14749
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
A-editor
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Sysix
force-pushed
the
10-18-test_editor_reduce_sleep_time
branch
from
327e2b3 to
23011a9
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR reduces the sleep duration in test helper functions from 500ms to 250ms to improve test execution speed. The change aims to optimize test performance while maintaining stability.
- Reduced sleep timers from 500ms to 250ms in test helper functions
- Added explicit sleep calls in specific test cases to ensure proper timing
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| editors/vscode/tests/test-helpers.ts | Reduced sleep duration from 500ms to 250ms in activateExtension and getDiagnosticsWithoutClose functions |
| editors/vscode/tests/e2e_server.spec.ts | Added explicit 250ms sleep calls in two test cases after loading fixtures |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
camc314
approved these changes
Oct 20, 2025
Contributor
Merge activity
|
graphite-app bot
pushed a commit
that referenced
this pull request
Oct 20, 2025
~~just looking if we can decrease the sleep timer~~ Looks stable
graphite-app
bot
force-pushed
the
10-18-test_editor_reduce_sleep_time
branch
from
23011a9 to
1cb0ced
Compare
graphite-app bot
pushed a commit
that referenced
this pull request
Oct 20, 2025
~~just looking if we can decrease the sleep timer~~ Looks stable
graphite-app
bot
force-pushed
the
10-18-test_editor_reduce_sleep_time
branch
from
1cb0ced to
f01815d
Compare
~~just looking if we can decrease the sleep timer~~ Looks stable
graphite-app
bot
force-pushed
the
10-18-test_editor_reduce_sleep_time
branch
from
f01815d to
faada4d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
just looking if we can decrease the sleep timerLooks stable