Skip to content

perf(language_server): avoid creating HashMap in Backend::did_change_watched_files #14735

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 17, 2025
Merged

perf(language_server): avoid creating HashMap in Backend::did_change_watched_files #14735

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 7 additions & 15 deletions crates/oxc_language_server/src/backend.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -403,8 +403,9 @@ impl LanguageServer for Backend {
let workers = self.workspace_workers.read().await;
// ToDo: what if an empty changes flag is passed?
debug!("watched file did change");
let all_diagnostics: papaya::HashMap<String, Vec<Diagnostic>, FxBuildHasher> =
ConcurrentHashMap::default();

let mut all_diagnostics = Vec::new();

for file_event in &params.changes {
// We do not expect multiple changes from the same workspace folder.
// If we should consider it, we need to map the events to the workers first,
Expand All @@ -418,24 +419,15 @@ impl LanguageServer for Backend {
continue;
};

for (key, value) in &diagnostics.pin() {
for (uri, reports) in &diagnostics.pin() {
all_diagnostics
.pin()
.insert(key.clone(), value.iter().map(|d| d.diagnostic.clone()).collect());
.push((uri.clone(), reports.iter().map(|d| d.diagnostic.clone()).collect()));
}
}

if all_diagnostics.is_empty() {
return;
if !all_diagnostics.is_empty() {
self.publish_all_diagnostics(&all_diagnostics).await;
}

let x = &all_diagnostics
.pin()
.into_iter()
.map(|(key, value)| (key.clone(), value.clone()))
.collect::<Vec<_>>();

self.publish_all_diagnostics(x).await;
}

/// The server will start new [WorkspaceWorker]s for added workspace folders
Expand Down
Loading