Skip to content

perf(linter): refactor no-labels to use top-level match on node kind #14688

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 17, 2025
Merged

perf(linter): refactor no-labels to use top-level match on node kind #14688

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion crates/oxc_linter/src/generated/rule_runner_impls.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -465,7 +465,11 @@ impl RuleRunner for crate::rules::eslint::no_label_var::NoLabelVar {
}

impl RuleRunner for crate::rules::eslint::no_labels::NoLabels {
const NODE_TYPES: Option<&AstTypesBitset> = None;
const NODE_TYPES: Option<&AstTypesBitset> = Some(&AstTypesBitset::from_types(&[
AstType::BreakStatement,
AstType::ContinueStatement,
AstType::LabeledStatement,
]));
const RUN_FUNCTIONS: RuleRunFunctionsImplemented = RuleRunFunctionsImplemented::Run;
}

Expand Down
47 changes: 24 additions & 23 deletions crates/oxc_linter/src/rules/eslint/no_labels.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,33 +141,34 @@ impl Rule for NoLabels {
}

fn run<'a>(&self, node: &AstNode<'a>, ctx: &LintContext<'a>) {
if let AstKind::LabeledStatement(labeled_stmt) = node.kind()
&& !self.is_allowed(&labeled_stmt.body)
{
let label_span = labeled_stmt.label.span;
ctx.diagnostic(no_labels_diagnostic("Labeled statement is not allowed", label_span));
}

if let AstKind::BreakStatement(break_stmt) = node.kind() {
let Some(label) = &break_stmt.label else { return };

if !self.is_allowed_in_break_or_continue(label, node.id(), ctx) {
match node.kind() {
AstKind::LabeledStatement(labeled_stmt) if !self.is_allowed(&labeled_stmt.body) => {
ctx.diagnostic(no_labels_diagnostic(
"Label in break statement is not allowed",
label.span,
"Labeled statement is not allowed",
labeled_stmt.label.span,
));
}
}

if let AstKind::ContinueStatement(cont_stmt) = node.kind() {
let Some(label) = &cont_stmt.label else { return };

if !self.is_allowed_in_break_or_continue(label, node.id(), ctx) {
ctx.diagnostic(no_labels_diagnostic(
"Label in continue statement is not allowed",
label.span,
));
AstKind::BreakStatement(break_stmt) => {
if let Some(label) = &break_stmt.label
&& !self.is_allowed_in_break_or_continue(label, node.id(), ctx)
{
ctx.diagnostic(no_labels_diagnostic(
"Label in break statement is not allowed",
label.span,
));
}
}
AstKind::ContinueStatement(cont_stmt) => {
if let Some(label) = &cont_stmt.label
&& !self.is_allowed_in_break_or_continue(label, node.id(), ctx)
{
ctx.diagnostic(no_labels_diagnostic(
"Label in continue statement is not allowed",
label.span,
));
}
}
_ => {}
}
}
}
Expand Down
Loading