perf(linter): rearrange rules for node type analysis

[camchenry]

Switching these rules to use a match node.kind() expression rather than multiple if let statements. Should be faster because we check node.kind() fewer times, plus the linter codegen recognizes this pattern automatically and can optimize skipping this rule when not needed.

+1% on all linter benchmarks.

[camchenry]

• perf(linter): switch if !matches!(node.kind(), ...) to match block #14650
• perf(linter): rearrange rules for node type analysis #14648 👈 (View in Graphite)
• main

---

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

• 0-merge - adds this PR to the back of the merge queue
• hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

[codspeed-hq]

CodSpeed Performance Report

Merging #14648 will not alter performance

_{Comparing 10-15-perf_linter_rearrange_rules_for_node_type_analysis (46ec4b6) with main (73f2cbb)}

Summary

✅ 4 untouched
⏩ 33 skipped¹

Footnotes

1. 33 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

[Copilot]

Pull Request Overview

Refactors linter rule implementations to use a single match on node.kind() instead of multiple if let chains, aiming for fewer kind() evaluations and improved performance.

• Consolidates conditional logic into match arms for PreferArrayFind.
• Converts two separate pattern checks into guarded match arms for NoUnreadableArrayDestructuring.

Reviewed Changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.

File	Description
crates/oxc_linter/src/rules/unicorn/prefer_array_find.rs	Reorganizes multiple pattern-specific if let checks into grouped match arms for different AstKind variants.
crates/oxc_linter/src/rules/unicorn/no_unreadable_array_destructuring.rs	Replaces sequential if let pattern checks with a match expression using guard clauses.

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

[camc314]

Merge activity

• Oct 16, 4:19 PM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
• Oct 16, 4:19 PM UTC: camc314 added this pull request to the Graphite merge queue.
• Oct 16, 4:23 PM UTC: Merged by the Graphite merge queue.