Skip to content

refactor(language_server): use Message span for Diagnostic's Range #14600

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 15, 2025
Merged

refactor(language_server): use Message span for Diagnostic's Range #14600

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 3 additions & 9 deletions crates/oxc_language_server/src/linter/error_with_position.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,15 +67,9 @@ pub fn message_to_lsp_diagnostic(
.collect()
});

let range = message.error.labels.as_ref().map_or(Range::default(), |labels| {
let offset = labels.first().map(|span| span.offset() as u32).unwrap_or_default();
let length = labels.first().map(|span| span.len() as u32).unwrap_or_default();

let start_position = offset_to_position(rope, offset, source_text);
let end_position = offset_to_position(rope, offset + length, source_text);

Range::new(start_position, end_position)
});
let start_position = offset_to_position(rope, message.span().start, source_text);
let end_position = offset_to_position(rope, message.span().end, source_text);
let range = Range::new(start_position, end_position);

let code = message.error.code.to_string();
let code_description = message
Expand Down
Loading