Skip to content

Conversation

@lilnasy
Copy link
Contributor

@lilnasy lilnasy commented Oct 13, 2025

CI on main seems to be failing since snapshot based tests were introduced.

This PR includes two fixes:

  • handling of backslashed paths when generating test code
  • normalization of crlf which, were counted as two line breaks by snapshot comparison

Looks like windows test job doen't run on pull requests or feature branches, it only runs on main. You can review its status on my fork's main workflow run: https://github.com/lilnasy/oxc/actions/runs/18458898920.

Copilot AI review requested due to automatic review settings October 13, 2025 08:02
@lilnasy lilnasy requested a review from Dunqing as a code owner October 13, 2025 08:02
@graphite-app
Copy link
Contributor

graphite-app bot commented Oct 13, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@github-actions github-actions bot added the A-formatter Area - Formatter label Oct 13, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes CI test failures on Windows by addressing path and line ending compatibility issues in the snapshot-based testing system. The changes ensure that tests run correctly on Windows by normalizing path separators and handling CRLF line endings.

  • Normalizes CRLF line endings to LF for consistent snapshot comparison across platforms
  • Converts Windows backslash path separators to forward slashes in generated test code
  • Adds a utility function to handle newline normalization

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
crates/oxc_formatter/build.rs Converts Windows path separators to forward slashes in generated test paths
crates/oxc_formatter/tests/fixtures/mod.rs Adds newline normalization for input files and formatted output, plus utility function

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@github-actions github-actions bot added the C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior label Oct 13, 2025
@codspeed-hq
Copy link

codspeed-hq bot commented Oct 13, 2025

CodSpeed Performance Report

Merging #14546 will not alter performance

Comparing lilnasy:main (20136d4) with main (5db9774)

Summary

✅ 33 untouched
⏩ 4 skipped1

Footnotes

  1. 4 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

Copy link
Member

@Dunqing Dunqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing this

@Dunqing Dunqing added the 0-merge Merge with Graphite Merge Queue label Oct 14, 2025
@graphite-app
Copy link
Contributor

graphite-app bot commented Oct 14, 2025

Merge activity

  • Oct 14, 3:01 AM UTC: @lilnasy we removed the merge queue label because we could not find a Graphite account associated with your GitHub profile.

You must have a Graphite account in order to use the merge queue. Create an account and try again using this link

@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Oct 14, 2025
@Dunqing Dunqing merged commit 2cd53c5 into oxc-project:main Oct 14, 2025
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-formatter Area - Formatter C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants