-
-
Notifications
You must be signed in to change notification settings - Fork 723
chore(ci): fix windows test #14546
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(ci): fix windows test #14546
Conversation
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes CI test failures on Windows by addressing path and line ending compatibility issues in the snapshot-based testing system. The changes ensure that tests run correctly on Windows by normalizing path separators and handling CRLF line endings.
- Normalizes CRLF line endings to LF for consistent snapshot comparison across platforms
- Converts Windows backslash path separators to forward slashes in generated test code
- Adds a utility function to handle newline normalization
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| crates/oxc_formatter/build.rs | Converts Windows path separators to forward slashes in generated test paths |
| crates/oxc_formatter/tests/fixtures/mod.rs | Adds newline normalization for input files and formatted output, plus utility function |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
CodSpeed Performance ReportMerging #14546 will not alter performanceComparing Summary
Footnotes
|
Dunqing
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for fixing this
CI on main seems to be failing since snapshot based tests were introduced.
This PR includes two fixes:
Looks like windows test job doen't run on pull requests or feature branches, it only runs on main. You can review its status on my fork's main workflow run: https://github.com/lilnasy/oxc/actions/runs/18458898920.