Skip to content

refactor(linter/no-import-assign): use let-else chain #14524

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 12, 2025
Merged

refactor(linter/no-import-assign): use let-else chain #14524

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
159 changes: 79 additions & 80 deletions crates/oxc_linter/src/rules/eslint/no_import_assign.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,92 +55,91 @@ const REFLECT_MUTATION_METHODS: [&str; 4] =

impl Rule for NoImportAssign {
fn run<'a>(&self, node: &AstNode<'a>, ctx: &LintContext<'a>) {
if let AstKind::ImportDeclaration(import_decl) = node.kind() {
let symbol_table = ctx.scoping();
if let Some(specifiers) = &import_decl.specifiers {
for specifier in specifiers {
let symbol_id = specifier.local().symbol_id();
let is_namespace_specifier = matches!(
specifier,
oxc_ast::ast::ImportDeclarationSpecifier::ImportNamespaceSpecifier(_)
);
for reference in symbol_table.get_resolved_references(symbol_id) {
if is_namespace_specifier {
let parent_node = ctx.nodes().parent_node(reference.node_id());
if parent_node.kind().is_member_expression_kind() {
let expr = parent_node.kind();
let parent_parent_node = ctx.nodes().parent_node(parent_node.id());
let is_unary_expression_with_delete_operator = |kind| {
matches!(
kind,
AstKind::UnaryExpression(expr)
if expr.operator == UnaryOperator::Delete
)
};
let parent_parent_kind = parent_parent_node.kind();
if (matches!(parent_parent_kind, AstKind::IdentifierReference(_))
|| is_unary_expression_with_delete_operator(parent_parent_kind)
|| matches!(parent_parent_kind, AstKind::ChainExpression(_) if is_unary_expression_with_delete_operator(ctx.nodes().parent_kind(parent_parent_node.id()))))
&& let Some((span, _)) = match expr {
AstKind::StaticMemberExpression(expr) => {
Some(expr.static_property_info())
}
AstKind::ComputedMemberExpression(expr) => {
expr.static_property_info()
}
_ => return,
}
&& span != ctx.semantic().reference_span(reference)
{
return ctx
.diagnostic(no_import_assign_diagnostic(expr.span()));
}
// Check for assignment to namespace property
match expr {
AstKind::StaticMemberExpression(member_expr) => {
let condition_met = is_assignment_condition_met(
&parent_parent_kind,
parent_node.span(),
true, // is_static
);
check_namespace_member_assignment(
&member_expr.object,
parent_node,
reference,
ctx,
condition_met,
);
let AstKind::ImportDeclaration(import_decl) = node.kind() else { return };

let symbol_table = ctx.scoping();
if let Some(specifiers) = &import_decl.specifiers {
for specifier in specifiers {
let symbol_id = specifier.local().symbol_id();
let is_namespace_specifier = matches!(
specifier,
oxc_ast::ast::ImportDeclarationSpecifier::ImportNamespaceSpecifier(_)
);
for reference in symbol_table.get_resolved_references(symbol_id) {
if is_namespace_specifier {
let parent_node = ctx.nodes().parent_node(reference.node_id());
if parent_node.kind().is_member_expression_kind() {
let expr = parent_node.kind();
let parent_parent_node = ctx.nodes().parent_node(parent_node.id());
let is_unary_expression_with_delete_operator = |kind| {
matches!(
kind,
AstKind::UnaryExpression(expr)
if expr.operator == UnaryOperator::Delete
)
};
let parent_parent_kind = parent_parent_node.kind();
if (matches!(parent_parent_kind, AstKind::IdentifierReference(_))
|| is_unary_expression_with_delete_operator(parent_parent_kind)
|| matches!(parent_parent_kind, AstKind::ChainExpression(_) if is_unary_expression_with_delete_operator(ctx.nodes().parent_kind(parent_parent_node.id()))))
&& let Some((span, _)) = match expr {
AstKind::StaticMemberExpression(expr) => {
Some(expr.static_property_info())
}
AstKind::ComputedMemberExpression(member_expr) => {
let condition_met = is_assignment_condition_met(
&parent_parent_kind,
parent_node.span(),
false, // is_static
);
check_namespace_member_assignment(
&member_expr.object,
parent_node,
reference,
ctx,
condition_met,
);
AstKind::ComputedMemberExpression(expr) => {
expr.static_property_info()
}
_ => {}
_ => return,
}
&& span != ctx.semantic().reference_span(reference)
{
return ctx.diagnostic(no_import_assign_diagnostic(expr.span()));
}
// Check for assignment to namespace property
match expr {
AstKind::StaticMemberExpression(member_expr) => {
let condition_met = is_assignment_condition_met(
&parent_parent_kind,
parent_node.span(),
true, // is_static
);
check_namespace_member_assignment(
&member_expr.object,
parent_node,
reference,
ctx,
condition_met,
);
}
AstKind::ComputedMemberExpression(member_expr) => {
let condition_met = is_assignment_condition_met(
&parent_parent_kind,
parent_node.span(),
false, // is_static
);
check_namespace_member_assignment(
&member_expr.object,
parent_node,
reference,
ctx,
condition_met,
);
}
_ => {}
}
}
}

if reference.is_write()
|| (is_namespace_specifier
&& is_argument_of_well_known_mutation_function(
reference.node_id(),
ctx,
))
{
ctx.diagnostic(no_import_assign_diagnostic(
ctx.semantic().reference_span(reference),
));
}
if reference.is_write()
|| (is_namespace_specifier
&& is_argument_of_well_known_mutation_function(
reference.node_id(),
ctx,
))
{
ctx.diagnostic(no_import_assign_diagnostic(
ctx.semantic().reference_span(reference),
));
}
}
}
Expand Down
Loading