Skip to content

fix(oxc_formatter): Fix arrow_parentheses: 'avoid' > 'as-needed' #14462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 9, 2025
+6 −4
Merged

fix(oxc_formatter): Fix arrow_parentheses: 'avoid' > 'as-needed' #14462

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions crates/oxc_formatter/src/options.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -596,8 +596,7 @@ impl FromStr for ArrowParentheses {

fn from_str(s: &str) -> Result<Self, Self::Err> {
match s {
// Prettier calls it `avoid`, but Biome calls it `AsNeeded`
"avoid" => Ok(Self::AsNeeded),
"as-needed" => Ok(Self::AsNeeded),
"always" => Ok(Self::Always),
_ => Err(
"Value not supported for Arrow parentheses. Supported values are 'as-needed' and 'always'.",
Expand Down
7 changes: 5 additions & 2 deletions tasks/prettier_conformance/src/spec.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,8 +187,11 @@ impl VisitMut<'_> for SpecParser {
}
"arrowParens" => {
// TODO: change `unwrap_or_default` to `unwrap`
options.arrow_parentheses =
ArrowParentheses::from_str(s).unwrap_or_default();
options.arrow_parentheses = ArrowParentheses::from_str(
// Prettier uses "avoid", but we use "as-needed"
if s == "avoid" { "as-needed" } else { s },
)
.unwrap_or_default();
}
"experimentalOperatorPosition" => {
// TODO: change `unwrap_or_default` to `unwrap`
Expand Down
Loading