Skip to content

Conversation

@leaysgur
Copy link
Member

@leaysgur leaysgur commented Oct 9, 2025

Just like StringLiteral({value}).

Copilot AI review requested due to automatic review settings October 9, 2025 04:54
@github-actions github-actions bot added A-ast Area - AST C-enhancement Category - New feature or request labels Oct 9, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enhances the debug representation of JSXText nodes by including their value content in the debug name output. This change improves debugging capabilities by making JSXText nodes more identifiable through their actual text content.

  • Modified JSXText debug formatting to include the text value

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link
Member Author

leaysgur commented Oct 9, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@leaysgur leaysgur changed the title feat(oxc_ast): Show JSXText({value}) in debug_name() feat(oxc_ast): Show JSXText({value}) in debug_name() Oct 9, 2025
@codspeed-hq
Copy link

codspeed-hq bot commented Oct 9, 2025

CodSpeed Performance Report

Merging #14461 will not alter performance

Comparing 10-09-feat_oxc_ast_show_jsxtext_value_in_debug_name_ (368829b) with main (5856bc9)1

Summary

✅ 37 untouched

Footnotes

  1. No successful run was found on main (368829b) during the generation of this report, so 5856bc9 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@leaysgur leaysgur requested a review from Boshen October 9, 2025 05:03
@Dunqing Dunqing changed the title feat(oxc_ast): Show JSXText({value}) in debug_name() feat(ast): Show JSXText({value}) in debug_name() Oct 9, 2025
@Dunqing Dunqing added the 0-merge Merge with Graphite Merge Queue label Oct 9, 2025
Copy link
Member

Dunqing commented Oct 9, 2025

Merge activity

Just like `StringLiteral({value})`.
@graphite-app graphite-app bot force-pushed the 10-09-feat_oxc_ast_show_jsxtext_value_in_debug_name_ branch from dc378f5 to 368829b Compare October 9, 2025 07:46
@graphite-app graphite-app bot merged commit 368829b into main Oct 9, 2025
27 checks passed
@graphite-app graphite-app bot deleted the 10-09-feat_oxc_ast_show_jsxtext_value_in_debug_name_ branch October 9, 2025 07:51
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Oct 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-ast Area - AST C-enhancement Category - New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants