Skip to content

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Oct 7, 2025

Pure refactor. Move code around in codegen for ESTree visitor. Does not alter the output of the codegen, purely moves logic.

@github-actions github-actions bot added the A-ast-tools Area - AST tools label Oct 7, 2025
@github-actions github-actions bot added the C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior label Oct 7, 2025
Copy link
Member Author

overlookmotel commented Oct 7, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@overlookmotel overlookmotel marked this pull request as ready for review October 7, 2025 23:22
@overlookmotel overlookmotel self-assigned this Oct 7, 2025
@graphite-app graphite-app bot added the 0-merge Merge with Graphite Merge Queue label Oct 7, 2025
@graphite-app
Copy link
Contributor

graphite-app bot commented Oct 7, 2025

Merge activity

Pure refactor. Move code around in codegen for ESTree visitor. Does not alter the output of the codegen, purely moves logic.
@graphite-app graphite-app bot force-pushed the 10-06-refactor_linter_plugins_split_adding_visit_function_to_compiler_visitor_into_multiple_functions branch from 7a9e6ad to 3b26bf3 Compare October 7, 2025 23:36
@graphite-app graphite-app bot requested a review from camc314 as a code owner October 7, 2025 23:36
@graphite-app graphite-app bot force-pushed the 10-06-refactor_ast_tools_refactor_generating_visitor_type_files branch from 5b839d5 to ccdb5ea Compare October 7, 2025 23:37
Base automatically changed from 10-06-refactor_linter_plugins_split_adding_visit_function_to_compiler_visitor_into_multiple_functions to main October 7, 2025 23:42
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Oct 7, 2025
@graphite-app graphite-app bot merged commit ccdb5ea into main Oct 7, 2025
19 checks passed
@graphite-app graphite-app bot deleted the 10-06-refactor_ast_tools_refactor_generating_visitor_type_files branch October 7, 2025 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-ast-tools Area - AST tools C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants