Skip to content

perf(linter/plugins): small perf optimizations #14420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 7, 2025
Merged

perf(linter/plugins): small perf optimizations #14420

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions apps/oxlint/src-js/plugins/context.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import type { Fix, FixFn } from './fix.ts';
import type { SourceCode } from './source_code.ts';
import type { Location, Ranged } from './types.ts';

const { hasOwn } = Object;
const { hasOwn, keys: ObjectKeys } = Object;

// Diagnostic in form passed by user to `Context#report()`
export type Diagnostic = DiagnosticWithNode | DiagnosticWithLoc | DiagnosticWithMessageId;
Expand Down Expand Up @@ -161,8 +161,7 @@ export class Context {
// Resolve message from messageId if present
let message: string;
if (hasOwn(diagnostic, 'messageId')) {
const diagWithMessageId = diagnostic as DiagnosticWithMessageId;
message = resolveMessage(diagWithMessageId.messageId, internal);
message = resolveMessage((diagnostic as DiagnosticWithMessageId).messageId, internal);
} else {
message = diagnostic.message;
if (typeof message !== 'string') {
Expand Down Expand Up @@ -249,15 +248,14 @@ export class Context {
*/
function resolveMessage(messageId: string, internal: InternalContext): string {
const { messages } = internal;

if (!messages) {
if (messages === null) {
throw new Error(`Cannot use messageId '${messageId}' - rule does not define any messages in meta.messages`);
}

if (!hasOwn(messages, messageId)) {
throw new Error(
`Unknown messageId '${messageId}'. Available messages: ${
Object.keys(messages).map((msg) => `'${msg}'`).join(', ')
ObjectKeys(messages).map((msg) => `'${msg}'`).join(', ')
}`,
);
}
Expand Down
9 changes: 4 additions & 5 deletions apps/oxlint/src-js/plugins/load.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,11 +134,10 @@ async function loadPluginImpl(path: string): Promise<PluginDetails> {
}

// Extract messages for messageId support
if (ruleMeta.messages != null) {
if (typeof ruleMeta.messages !== 'object' || Array.isArray(ruleMeta.messages)) {
throw new TypeError('Invalid `meta.messages` - must be an object');
}
messages = ruleMeta.messages;
const inputMessages = ruleMeta.messages;
if (inputMessages != null) {
if (typeof inputMessages !== 'object') throw new TypeError('`meta.messages` must be an object if provided');
messages = inputMessages;
}
}

Expand Down
Loading