-
-
Notifications
You must be signed in to change notification settings - Fork 721
ci(napi): remove redundant step from workflow + add comment #14412
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci(napi): remove redundant step from workflow + add comment #14412
Conversation
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR performs CI workflow cleanup by removing redundant Windows-specific configuration from the NAPI test job and adds documentation for test timeout settings. The changes improve workflow efficiency and code clarity.
- Removed unnecessary Windows long paths configuration from NAPI test job
- Added explanatory comment for ESLint compatibility test timeout setting
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| .github/workflows/ci.yml | Removed redundant Windows long paths step from NAPI test job |
| apps/oxlint/test/eslint-compat.test.ts | Added comment explaining the 10-second timeout for CI performance |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Merge activity
|
|
Minor changes, so merging without review. |
Follow-on after #14383. Remove redundant lines from workflow + add a comment about why longer timeout on ESLint compat tests.
e97bc34 to
3192574
Compare

Follow-on after #14383. Remove redundant lines from workflow + add a comment about why longer timeout on ESLint compat tests.