Skip to content

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Oct 7, 2025

Follow-on after #14383. Remove redundant lines from workflow + add a comment about why longer timeout on ESLint compat tests.

@github-actions github-actions bot added A-linter Area - Linter A-cli Area - CLI labels Oct 7, 2025
Copy link
Member Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@overlookmotel overlookmotel marked this pull request as ready for review October 7, 2025 14:20
@overlookmotel overlookmotel requested a review from camc314 as a code owner October 7, 2025 14:20
Copilot AI review requested due to automatic review settings October 7, 2025 14:20
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR performs CI workflow cleanup by removing redundant Windows-specific configuration from the NAPI test job and adds documentation for test timeout settings. The changes improve workflow efficiency and code clarity.

  • Removed unnecessary Windows long paths configuration from NAPI test job
  • Added explanatory comment for ESLint compatibility test timeout setting

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
.github/workflows/ci.yml Removed redundant Windows long paths step from NAPI test job
apps/oxlint/test/eslint-compat.test.ts Added comment explaining the 10-second timeout for CI performance

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@overlookmotel overlookmotel self-assigned this Oct 7, 2025
@overlookmotel overlookmotel added the 0-merge Merge with Graphite Merge Queue label Oct 7, 2025
Copy link
Member Author

overlookmotel commented Oct 7, 2025

Merge activity

@overlookmotel
Copy link
Member Author

Minor changes, so merging without review.

Follow-on after #14383. Remove redundant lines from workflow + add a comment about why longer timeout on ESLint compat tests.
@graphite-app graphite-app bot force-pushed the 10-07-ci_napi_remove_redundant_step_from_workflow_add_comment branch from e97bc34 to 3192574 Compare October 7, 2025 14:25
@graphite-app graphite-app bot merged commit 3192574 into main Oct 7, 2025
20 checks passed
@graphite-app graphite-app bot deleted the 10-07-ci_napi_remove_redundant_step_from_workflow_add_comment branch October 7, 2025 14:30
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Oct 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-cli Area - CLI A-linter Area - Linter

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants