Skip to content

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Oct 7, 2025

Fix a bug in Vitest config for napi/parser package. When providing exclude property, should extend the default to prevent Vitest searching node_modules for test files (docs).

Also refactor to clarify the logic of which tests are skipped depending on different env vars.

@github-actions github-actions bot added A-parser Area - Parser C-test Category - Testing. Code is missing test cases, or a PR is adding them labels Oct 7, 2025
Copy link
Member Author

overlookmotel commented Oct 7, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@overlookmotel overlookmotel marked this pull request as ready for review October 7, 2025 11:20
@camc314 camc314 changed the base branch from c/10-06-ci_run_napi_tests_on_windows to graphite-base/14409 October 7, 2025 11:24
@overlookmotel overlookmotel added the 0-merge Merge with Graphite Merge Queue label Oct 7, 2025
Copy link
Member Author

overlookmotel commented Oct 7, 2025

Merge activity

  • Oct 7, 2:15 PM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Oct 7, 2:15 PM UTC: This pull request can not be added to the Graphite merge queue. Please try rebasing and resubmitting to merge when ready.
  • Oct 7, 2:15 PM UTC: Graphite disabled "merge when ready" on this PR due to: a merge conflict with the target branch; resolve the conflict and try again..
  • Oct 7, 2:15 PM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Oct 7, 3:53 PM UTC: overlookmotel added this pull request to the Graphite merge queue.
  • Oct 7, 3:59 PM UTC: Merged by the Graphite merge queue.

@overlookmotel overlookmotel force-pushed the 10-07-test_napi_parser_fix_and_clarify_exclude_tests_logic branch from 8a228a7 to f2cbdbe Compare October 7, 2025 14:32
@overlookmotel overlookmotel changed the base branch from graphite-base/14409 to main October 7, 2025 14:32
@overlookmotel overlookmotel force-pushed the 10-07-test_napi_parser_fix_and_clarify_exclude_tests_logic branch from f2cbdbe to eb7c93a Compare October 7, 2025 15:48
Fix a bug in Vitest config for `napi/parser` package. When providing `exclude` property, should extend the default to prevent Vitest searching `node_modules` for test files ([docs](https://vitest.dev/config/)).

Also refactor to clarify the logic of which tests are skipped depending on different `env` vars.
@graphite-app graphite-app bot force-pushed the 10-07-test_napi_parser_fix_and_clarify_exclude_tests_logic branch from eb7c93a to 0b076b4 Compare October 7, 2025 15:54
@graphite-app graphite-app bot merged commit 0b076b4 into main Oct 7, 2025
18 checks passed
@graphite-app graphite-app bot deleted the 10-07-test_napi_parser_fix_and_clarify_exclude_tests_logic branch October 7, 2025 15:59
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Oct 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-parser Area - Parser C-test Category - Testing. Code is missing test cases, or a PR is adding them

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants