-
-
Notifications
You must be signed in to change notification settings - Fork 722
test(napi/parser): fix and clarify exclude tests logic #14409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
graphite-app
merged 1 commit into
main
from
10-07-test_napi_parser_fix_and_clarify_exclude_tests_logic
Oct 7, 2025
Merged
test(napi/parser): fix and clarify exclude tests logic #14409
graphite-app
merged 1 commit into
main
from
10-07-test_napi_parser_fix_and_clarify_exclude_tests_logic
Oct 7, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 7, 2025
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
camc314
approved these changes
Oct 7, 2025
Member
Author
Merge activity
|
46a0999 to
0ec0847
Compare
8a228a7 to
f2cbdbe
Compare
f2cbdbe to
eb7c93a
Compare
Fix a bug in Vitest config for `napi/parser` package. When providing `exclude` property, should extend the default to prevent Vitest searching `node_modules` for test files ([docs](https://vitest.dev/config/)). Also refactor to clarify the logic of which tests are skipped depending on different `env` vars.
eb7c93a to
0b076b4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.

Fix a bug in Vitest config for
napi/parserpackage. When providingexcludeproperty, should extend the default to prevent Vitest searchingnode_modulesfor test files (docs).Also refactor to clarify the logic of which tests are skipped depending on different
envvars.