-
-
Notifications
You must be signed in to change notification settings - Fork 722
fix(ast): skip source_text and comments fields in ContentEq for Program
#14370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ast): skip source_text and comments fields in ContentEq for Program
#14370
Conversation
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR excludes the source_text and comments fields from semantic content comparison in the Program struct by adding #[content_eq(skip)] attributes. The change ensures that ContentEq comparisons focus on semantically meaningful AST content rather than incidental metadata like source text and comments.
- Added
#[content_eq(skip)]attributes to exclude non-semantic fields from equality comparison - Applied to both
source_textandcommentsfields in theProgramstruct
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
Not sure who should review this. I've assigned to myself. If no-one has comments within a day or two, I'll merge it. |
CodSpeed Performance ReportMerging #14370 will not alter performanceComparing Summary
Footnotes |
Merge activity
|
… `Program` (#14370) `source_text` is not semantically meaningful, and comments is *mostly* not either. Exclude both from `ContentEq` comparison for `Program`.
29cd773 to
a86ca0b
Compare

source_textis not semantically meaningful, and comments is mostly not either. Exclude both fromContentEqcomparison forProgram.