feat(napi/parser): add option to add parent prop to AST nodes with raw transfer
#14344
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
A-parser
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
CodSpeed Instrumentation Performance ReportMerging #14344 will not alter performanceComparing Summary
Footnotes |
Contributor
Merge activity
|
…raw transfer (#14344) Add an option to `oxc-parser` to add `parent` to all AST nodes. This option is only available with raw transfer (not really feasible with JSON transfer, as JSON doesn't support circular references). This is really for the purposes of JS plugins in Oxlint, so have not included the new deserializers which add `parent` in the `oxc-parser` NPM package, to avoid bloating download size. But it's ideal home is in `napi/parser` so can add it to the conformance tests. `parent` is correct for all nodes in all Test262 and TypeScript test cases.
graphite-app
bot
force-pushed
the
10-04-refactor_ast_tools_raw_transfer_generate_deserializers_in_loop
branch
from
f4119a6 to
08f14e6
Compare
graphite-app
bot
force-pushed
the
10-04-feat_napi_parser_add_option_to_add_parent_prop_to_ast_nodes_with_raw_transfer
branch
from
2fed560 to
7e4d04f
Compare
graphite-app bot
pushed a commit
that referenced
this pull request
Oct 5, 2025
Use the new raw transfer deserializer added in #14344 to add `parent` field to all AST node in Oxlint JS plugins.
Base automatically changed from
10-04-refactor_ast_tools_raw_transfer_generate_deserializers_in_loop
to
main
October 5, 2025 00:37
graphite-app
bot
deleted the
10-04-feat_napi_parser_add_option_to_add_parent_prop_to_ast_nodes_with_raw_transfer
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an option to
oxc-parserto addparentto all AST nodes. This option is only available with raw transfer (not really feasible with JSON transfer, as JSON doesn't support circular references).This is really for the purposes of JS plugins in Oxlint, so have not included the new deserializers which add
parentin theoxc-parserNPM package, to avoid bloating download size. But it's ideal home is innapi/parserso can add it to the conformance tests.parentis correct for all nodes in all Test262 and TypeScript test cases.