Skip to content

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Oct 4, 2025

Follow-on after #14211. Add comments reflecting conversation we had on that PR.

Copy link
Member Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added the C-docs Category - Documentation. Related to user-facing or internal documentation label Oct 4, 2025
@overlookmotel overlookmotel marked this pull request as ready for review October 4, 2025 09:07
Copilot AI review requested due to automatic review settings October 4, 2025 09:07
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds comprehensive documentation comments to the HashMap::from_iter_in method in the allocator crate, explaining the implementation decisions and trade-offs made during iterator-based HashMap construction.

Key Changes

  • Added detailed comments explaining the use of the iterator's lower size bound for capacity estimation
  • Documented the trade-offs between potential reallocation vs over-allocation
  • Added comments explaining the strategic placement of ManuallyDrop wrapper

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@codspeed-hq
Copy link

codspeed-hq bot commented Oct 4, 2025

CodSpeed Instrumentation Performance Report

Merging #14329 will not alter performance

Comparing 10-04-docs_allocator_hashmap_add_comments_to_hashmap_from_iter_in_ (0c14e50) with main (7a1c339)

Summary

✅ 37 untouched

@overlookmotel overlookmotel self-assigned this Oct 4, 2025
@overlookmotel overlookmotel added the 0-merge Merge with Graphite Merge Queue label Oct 4, 2025
Copy link
Member Author

overlookmotel commented Oct 4, 2025

Merge activity

)

Follow-on after #14211. Add comments reflecting conversation we had on that PR.
@graphite-app graphite-app bot force-pushed the 10-04-docs_allocator_hashmap_add_comments_to_hashmap_from_iter_in_ branch from 8122fcf to 0c14e50 Compare October 4, 2025 09:15
@graphite-app graphite-app bot merged commit 0c14e50 into main Oct 4, 2025
28 checks passed
@graphite-app graphite-app bot deleted the 10-04-docs_allocator_hashmap_add_comments_to_hashmap_from_iter_in_ branch October 4, 2025 09:21
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Oct 4, 2025
@Boshen Boshen mentioned this pull request Oct 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C-docs Category - Documentation. Related to user-facing or internal documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants