Skip to content

Conversation

@sapphi-red
Copy link
Member

No description provided.

@github-actions github-actions bot added the A-minifier Area - Minifier label Oct 3, 2025
Copy link
Member Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added the C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior label Oct 3, 2025
@codspeed-hq
Copy link

codspeed-hq bot commented Oct 3, 2025

CodSpeed Instrumentation Performance Report

Merging #14322 will not alter performance

Comparing 10-04-refactor_minifier_use_oxc_ast_none_ (11dd63b) with main (5d3114c)

Summary

✅ 33 untouched
⏩ 4 skipped1

Footnotes

  1. 4 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@sapphi-red sapphi-red marked this pull request as ready for review October 3, 2025 16:37
Copilot AI review requested due to automatic review settings October 3, 2025 16:37
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors the minifier code to use the oxc_ast::NONE constant instead of the verbose Option::<TSTypeParameterInstantiation>::None syntax. This improves code readability and consistency by using a more concise shorthand for expressing None values in TypeScript type parameter instantiation contexts.

  • Adds NONE import to the oxc_ast module usage
  • Replaces multiple instances of explicit None type annotations with the NONE constant

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
crates/oxc_minifier/src/peephole/substitute_alternate_syntax.rs Replaced verbose None syntax with NONE constant in two call expression constructions
crates/oxc_minifier/src/peephole/replace_known_methods.rs Added NONE import and replaced verbose None syntax in three call expression constructions

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@graphite-app
Copy link
Contributor

graphite-app bot commented Oct 3, 2025

Merge activity

@graphite-app graphite-app bot force-pushed the 10-04-refactor_minifier_use_oxc_ast_none_ branch from d0a218a to 11dd63b Compare October 3, 2025 16:38
@graphite-app graphite-app bot merged commit 11dd63b into main Oct 3, 2025
26 checks passed
@graphite-app graphite-app bot deleted the 10-04-refactor_minifier_use_oxc_ast_none_ branch October 3, 2025 16:44
@Boshen Boshen mentioned this pull request Oct 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-minifier Area - Minifier C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants