-
-
Notifications
You must be signed in to change notification settings - Fork 721
refactor(minifier): use oxc_ast::NONE
#14322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
CodSpeed Instrumentation Performance ReportMerging #14322 will not alter performanceComparing Summary
Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR refactors the minifier code to use the oxc_ast::NONE constant instead of the verbose Option::<TSTypeParameterInstantiation>::None syntax. This improves code readability and consistency by using a more concise shorthand for expressing None values in TypeScript type parameter instantiation contexts.
- Adds
NONEimport to theoxc_astmodule usage - Replaces multiple instances of explicit None type annotations with the
NONEconstant
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| crates/oxc_minifier/src/peephole/substitute_alternate_syntax.rs | Replaced verbose None syntax with NONE constant in two call expression constructions |
| crates/oxc_minifier/src/peephole/replace_known_methods.rs | Added NONE import and replaced verbose None syntax in three call expression constructions |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Merge activity
|
d0a218a to
11dd63b
Compare

No description provided.