Skip to content

feat(napi/parser): raw transfer support range field #14319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 4, 2025
Merged

feat(napi/parser): raw transfer support range field #14319

merged 1 commit into from
Oct 4, 2025

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Oct 3, 2025 •
edited
Loading

Raw transfer support range option, adding range field to every AST node.

@github-actions github-actions bot added A-parser Area - Parser A-ast Area - AST A-ast-tools Area - AST tools C-enhancement Category - New feature or request labels Oct 3, 2025
This was referenced Oct 3, 2025
Merged
Merged
Merged
@overlookmotel Graphite App
Copy link
Member Author

overlookmotel commented Oct 3, 2025 •
edited
Loading

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@overlookmotel overlookmotel mentioned this pull request Oct 3, 2025
Merged
@codspeed-hq
Copy link

codspeed-hq bot commented Oct 3, 2025 •
edited
Loading

CodSpeed Instrumentation Performance Report

Merging #14319 will not alter performance

Comparing 10-03-feat_napi_parser_raw_transfer_support_range_field (6374065) with main (34e1c0b)1

Summary

✅ 37 untouched

Footnotes

  1. No successful run was found on main (c65e782) during the generation of this report, so 34e1c0b was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

@overlookmotel overlookmotel marked this pull request as ready for review October 3, 2025 15:57
@overlookmotel overlookmotel self-assigned this Oct 3, 2025
This was referenced Oct 3, 2025
Merged
Open
Open
@overlookmotel overlookmotel force-pushed the 10-03-fix_napi_parser_fix_jsdoc_comments branch from 6af5548 to 85948c9 Compare October 4, 2025 12:38
@overlookmotel overlookmotel force-pushed the 10-03-feat_napi_parser_raw_transfer_support_range_field branch 2 times, most recently from 4eb0da8 to 6626442 Compare October 4, 2025 12:58
@graphite-app graphite-app bot added the 0-merge Merge with Graphite Merge Queue label Oct 4, 2025
@graphite-app
Copy link
Contributor

graphite-app bot commented Oct 4, 2025 •
edited
Loading

Merge activity

@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Oct 4, 2025
@overlookmotel overlookmotel force-pushed the 10-03-feat_napi_parser_raw_transfer_support_range_field branch from 6626442 to ee8c0e1 Compare October 4, 2025 15:42
@overlookmotel overlookmotel force-pushed the 10-03-fix_napi_parser_fix_jsdoc_comments branch from 85948c9 to ef685c8 Compare October 4, 2025 15:42
@graphite-app graphite-app bot added the 0-merge Merge with Graphite Merge Queue label Oct 4, 2025
@overlookmotel
feat(napi/parser): raw transfer support range field (#14319)
6374065 
Raw transfer support `range` option, adding `range` field to every AST node.
@graphite-app graphite-app bot force-pushed the 10-03-fix_napi_parser_fix_jsdoc_comments branch from ef685c8 to c65e782 Compare October 4, 2025 15:48
@graphite-app graphite-app bot force-pushed the 10-03-feat_napi_parser_raw_transfer_support_range_field branch from ee8c0e1 to 6374065 Compare October 4, 2025 15:48
graphite-app bot pushed a commit that referenced this pull request Oct 4, 2025
@overlookmotel
feat(linter/plugins): include range field in AST (#14321)
5505a86 
Add `range` field to AST nodes, using the support for `range` in raw transfer added in #14319.

Use `range` field rather than `start` + `end` in nodes passed to `context.report` and fixer methods - for closer alignment with ESLint.
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Oct 4, 2025
Base automatically changed from 10-03-fix_napi_parser_fix_jsdoc_comments to main October 4, 2025 15:53
@graphite-app graphite-app bot merged commit 6374065 into main Oct 4, 2025
28 checks passed
@graphite-app graphite-app bot deleted the 10-03-feat_napi_parser_raw_transfer_support_range_field branch October 4, 2025 15:54
@Boshen Boshen mentioned this pull request Oct 6, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@overlookmotel overlookmotel

Labels

A-ast Area - AST A-ast-tools Area - AST tools A-parser Area - Parser C-enhancement Category - New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@overlookmotel