Skip to content

Conversation

@sapphi-red
Copy link
Member

@sapphi-red sapphi-red commented Oct 3, 2025

@github-actions github-actions bot added A-minifier Area - Minifier C-performance Category - Solution not expected to change functional behavior, only performance labels Oct 3, 2025
Copy link
Member Author

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@codspeed-hq
Copy link

codspeed-hq bot commented Oct 3, 2025

CodSpeed Instrumentation Performance Report

Merging #14314 will not alter performance

Comparing 10-03-perf_minifier_use_hashset_insert_unique_unchecked_ (56aef14) with main (0a42d7f)1

Summary

✅ 37 untouched

Footnotes

  1. No successful run was found on 09-28-feat-allocator-add-hashset (2799748) during the generation of this report, so main (0a42d7f) was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@sapphi-red
Copy link
Member Author

Doesn't seem to improve

@sapphi-red sapphi-red closed this Oct 3, 2025
@overlookmotel
Copy link
Member

Doesn't seem to improve

Thanks for trying it, anyway.

@overlookmotel overlookmotel deleted the 10-03-perf_minifier_use_hashset_insert_unique_unchecked_ branch October 4, 2025 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-minifier Area - Minifier C-performance Category - Solution not expected to change functional behavior, only performance

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants