feat(transformer): replace tab-to-space hack with native indent configuration #14191
+82
−82
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR replaces manual tab-to-space string replacement workarounds with proper native indentation configuration in the transformer conformance testing code.
- Configures
CodegenOptionsto use spaces with width 2 instead of post-processing tabs - Removes three instances of
cow_replace("\t", " ")string replacement calls - Adds necessary
IndentCharimports to support the configuration
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
tasks/transform_conformance/src/test_case.rs |
Removes tab-to-space replacements and configures Codegen with space indentation |
tasks/transform_conformance/src/driver.rs |
Configures Driver's codegen options to use space indentation |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Contributor
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
github-actions
bot
added
A-transformer
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
Boshen
force-pushed
the
feat/transformer-native-indent-config
branch
from
e1bf175 to
434cd6e
Compare
Member
Author
Merge activity
|
Boshen
added
0-merge
…guration (#14191) ## Summary - Closes oxc-project/backlog#150 - Replaces manual tab-to-space replacement hack with native indentation configuration ## Changes - Configure `Driver::codegen_options()` to use spaces with width 2 - Configure `TestCase` Codegen instance to use spaces with width 2 - Remove three instances of `cow_replace("\t", " ")` hack - Add `IndentChar` imports where needed ## Context The `CodegenOptions` struct already had `indent_char` and `indent_width` fields available. This change leverages existing infrastructure to provide cleaner, more maintainable code instead of post-processing the output with string replacement. This addresses the issue mentioned in oxc-project/backlog#150 where transformer conformance output was replacing tabs with spaces as a workaround. 🤖 Generated with [Claude Code](https://claude.ai/code)
graphite-app
bot
force-pushed
the
feat/transformer-native-indent-config
branch
from
52db5a1 to
5dcc64c
Compare
taearls
pushed a commit
to taearls/oxc
that referenced
this pull request
Sep 28, 2025
…guration (oxc-project#14191) ## Summary - Closes oxc-project/backlog#150 - Replaces manual tab-to-space replacement hack with native indentation configuration ## Changes - Configure `Driver::codegen_options()` to use spaces with width 2 - Configure `TestCase` Codegen instance to use spaces with width 2 - Remove three instances of `cow_replace("\t", " ")` hack - Add `IndentChar` imports where needed ## Context The `CodegenOptions` struct already had `indent_char` and `indent_width` fields available. This change leverages existing infrastructure to provide cleaner, more maintainable code instead of post-processing the output with string replacement. This addresses the issue mentioned in oxc-project/backlog#150 where transformer conformance output was replacing tabs with spaces as a workaround. 🤖 Generated with [Claude Code](https://claude.ai/code)
taearls
pushed a commit
to taearls/oxc
that referenced
this pull request
Sep 28, 2025
…guration (oxc-project#14191) ## Summary - Closes oxc-project/backlog#150 - Replaces manual tab-to-space replacement hack with native indentation configuration ## Changes - Configure `Driver::codegen_options()` to use spaces with width 2 - Configure `TestCase` Codegen instance to use spaces with width 2 - Remove three instances of `cow_replace("\t", " ")` hack - Add `IndentChar` imports where needed ## Context The `CodegenOptions` struct already had `indent_char` and `indent_width` fields available. This change leverages existing infrastructure to provide cleaner, more maintainable code instead of post-processing the output with string replacement. This addresses the issue mentioned in oxc-project/backlog#150 where transformer conformance output was replacing tabs with spaces as a workaround. 🤖 Generated with [Claude Code](https://claude.ai/code)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changes
Driver::codegen_options()to use spaces with width 2TestCaseCodegen instance to use spaces with width 2cow_replace("\t", " ")hackIndentCharimports where neededContext
The
CodegenOptionsstruct already hadindent_charandindent_widthfields available. This change leverages existing infrastructure to provide cleaner, more maintainable code instead of post-processing the output with string replacement.This addresses the issue mentioned in #14236 where transformer conformance output was replacing tabs with spaces as a workaround.
🤖 Generated with Claude Code