-
-
Notifications
You must be signed in to change notification settings - Fork 721
fix(minifier): remove continue in the end of for-in / for-of
#14186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(minifier): remove continue in the end of for-in / for-of
#14186
Conversation
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes the JavaScript minifier to remove unnecessary continue statements at the end of for-in and for-of loop bodies, making the generated code more concise. The fix ensures that continue statements that would be the last statement executed in a loop iteration are removed since they have no effect.
Key changes:
- Extended the condition to handle for-in and for-of loops in addition to regular for loops
- Added test cases to verify the optimization works for all three loop types
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
CodSpeed Instrumentation Performance ReportMerging #14186 will not alter performanceComparing Summary
Footnotes
|
Merge activity
|
Compress
```js
for (a of b) { c(); continue; }
for (a in b) { c(); continue; }
```
to
```js
for (a of b) { c(); }
for (a in b) { c(); }
```
d038b54 to
e4e963b
Compare

Compress
to