fix(minifier): don't inline single use variable in conditional logical expressions

[sapphi-red]

oxc/crates/oxc_minifier/src/peephole/minimize_statements.rs

Lines 1427 to 1429 in 358f2fc

	// Do not substitute our unconditionally-executed value into a branch
	// unless the value itself has no side effects
	if !replacement_has_side_effect {

This should be handled in logical expressions as well, but was not handled.

[sapphi-red]

• fix(minifier): don't inline single use variable in conditional logical expressions #14185 👈 (View in Graphite)
• feat(minifier): inline single-use variable past read-only variables #14184
• main

---

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

• 0-merge - adds this PR to the back of the merge queue
• hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

[codspeed-hq]

CodSpeed Instrumentation Performance Report

Merging #14185 will degrade performances by 10.12%

_{Comparing 09-27-fix_minifier_don_t_inline_single_use_variable_in_conditional_logical_expressions (6b2daa8) with main (e4e963b)¹}

Summary

❌ 1 regression
✅ 32 untouched
⏩ 4 skipped²

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

	Benchmark	BASE	HEAD	Change
❌	minifier[cal.com.tsx]	32.7 ms	36.4 ms	-10.12%

Footnotes

1. No successful run was found on main (6b2daa8) during the generation of this report, so e4e963b was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

2. 4 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

[Boshen]

Merge activity

• Oct 1, 4:55 AM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
• Oct 1, 4:55 AM UTC: Boshen added this pull request to the Graphite merge queue.
• Oct 1, 5:18 AM UTC: Merged by the Graphite merge queue.