-
-
Notifications
You must be signed in to change notification settings - Fork 723
fix(napi): rebuild bindings file for NAPI packages #13889
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(napi): rebuild bindings file for NAPI packages #13889
Conversation
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Updates NAPI binding version checks from 0.89.0 to 0.90.0 across all binding files to fix CI issues caused by outdated version references.
- Updates version checks in native binding loader functions from "0.89.0" to "0.90.0"
- Fixes CI failures by ensuring binding files reflect current package versions
- Updates error messages to reference the correct expected version number
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| napi/transform/index.js | Updates all platform-specific binding version checks from 0.89.0 to 0.90.0 |
| napi/parser/bindings.mjs | Updates all platform-specific binding version checks from 0.89.0 to 0.90.0 |
| napi/minify/index.js | Updates all platform-specific binding version checks from 0.89.0 to 0.90.0 |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Merge activity
|
|
@Boshen how should we go about fixing the release mechanism to avoid this happening every time? |
#13888 broke CI because it didn't run `pnpm build` to update version number in NAPI bindings files. I don't think the published packages are broken, because it only matters if `NAPI_RS_ENFORCE_VERSION_CHECK` env is set.
35d83d2 to
21bbf95
Compare

#13888 broke CI because it didn't run
pnpm buildto update version number in NAPI bindings files.I don't think the published packages are broken, because it only matters if
NAPI_RS_ENFORCE_VERSION_CHECKenv is set.