Skip to content

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Sep 18, 2025

#13888 broke CI because it didn't run pnpm build to update version number in NAPI bindings files.

I don't think the published packages are broken, because it only matters if NAPI_RS_ENFORCE_VERSION_CHECK env is set.

@github-actions github-actions bot added A-parser Area - Parser A-minifier Area - Minifier A-transformer Area - Transformer / Transpiler C-bug Category - Bug labels Sep 18, 2025
Copy link
Member Author

overlookmotel commented Sep 18, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@overlookmotel overlookmotel marked this pull request as ready for review September 18, 2025 14:34
Copilot AI review requested due to automatic review settings September 18, 2025 14:34
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Updates NAPI binding version checks from 0.89.0 to 0.90.0 across all binding files to fix CI issues caused by outdated version references.

  • Updates version checks in native binding loader functions from "0.89.0" to "0.90.0"
  • Fixes CI failures by ensuring binding files reflect current package versions
  • Updates error messages to reference the correct expected version number

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
napi/transform/index.js Updates all platform-specific binding version checks from 0.89.0 to 0.90.0
napi/parser/bindings.mjs Updates all platform-specific binding version checks from 0.89.0 to 0.90.0
napi/minify/index.js Updates all platform-specific binding version checks from 0.89.0 to 0.90.0

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@overlookmotel overlookmotel self-assigned this Sep 18, 2025
@overlookmotel overlookmotel added the 0-merge Merge with Graphite Merge Queue label Sep 18, 2025
Copy link
Member Author

overlookmotel commented Sep 18, 2025

Merge activity

@overlookmotel
Copy link
Member Author

@Boshen how should we go about fixing the release mechanism to avoid this happening every time?

#13888 broke CI because it didn't run `pnpm build` to update version number in NAPI bindings files.

I don't think the published packages are broken, because it only matters if `NAPI_RS_ENFORCE_VERSION_CHECK` env is set.
@graphite-app graphite-app bot force-pushed the 09-18-fix_napi_rebuild_bindings_file_for_napi_packages branch from 35d83d2 to 21bbf95 Compare September 18, 2025 14:37
@graphite-app graphite-app bot merged commit 21bbf95 into main Sep 18, 2025
18 checks passed
@graphite-app graphite-app bot deleted the 09-18-fix_napi_rebuild_bindings_file_for_napi_packages branch September 18, 2025 14:42
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Sep 18, 2025
@overlookmotel
Copy link
Member Author

@Boshen how should we go about fixing the release mechanism to avoid this happening every time?

Hopefully #13895 will do the trick.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-minifier Area - Minifier A-parser Area - Parser A-transformer Area - Transformer / Transpiler C-bug Category - Bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants