-
-
Notifications
You must be signed in to change notification settings - Fork 723
docs(parser): improve docs for Token::read_bool
#13873
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(parser): improve docs for Token::read_bool
#13873
Conversation
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR improves the documentation for the Token::read_bool method by correcting inaccurate assembly examples and reorganizing the content for better clarity.
Key changes:
- Replace AI-generated assembly examples with actual assembly code from compiler output
- Move the safety documentation above performance analysis for better prioritization
- Add a link to Godbolt for verification of assembly examples
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Merge activity
|
CodSpeed Instrumentation Performance ReportMerging #13873 will not alter performanceComparing Summary
Footnotes |
8129bd1 to
3a03b85
Compare

Follow-on after #13867.
Correct the assembly examples. AI copied its invented assembly from #13788. Replace it with the actual assembly!
Also move the
# SAFETYcomment higher up, as that's more important than the perf analysis.