Skip to content

Conversation

@nnnnoel
Copy link
Contributor

@nnnnoel nnnnoel commented Sep 16, 2025

No description provided.

@nnnnoel nnnnoel requested a review from Dunqing as a code owner September 16, 2025 05:28
@graphite-app
Copy link
Contributor

graphite-app bot commented Sep 16, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@github-actions github-actions bot added A-formatter Area - Formatter C-bug Category - Bug labels Sep 16, 2025
@codspeed-hq
Copy link

codspeed-hq bot commented Sep 16, 2025

CodSpeed Instrumentation Performance Report

Merging #13806 will not alter performance

Comparing nnnnoel:fix/private-in-expression (6fe0265) with main (7879f85)

Summary

✅ 37 untouched

Copy link
Member

@Dunqing Dunqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can use is_class_extends here

fn is_class_extends(span: Span, parent: &AstNodes<'_>) -> bool {
if let AstNodes::Class(c) = parent {
return c.super_class.as_ref().is_some_and(|c| c.without_parentheses().span() == span);
}
false
}

@nnnnoel nnnnoel requested a review from Dunqing September 16, 2025 09:58
@Dunqing Dunqing force-pushed the fix/private-in-expression branch from b41ef82 to 6a18235 Compare September 16, 2025 10:08
@nnnnoel nnnnoel force-pushed the fix/private-in-expression branch from 6a18235 to 6fe0265 Compare September 17, 2025 04:02
Copy link
Member

@Dunqing Dunqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution!

@Dunqing Dunqing merged commit b43ad49 into oxc-project:main Sep 17, 2025
27 checks passed
This was referenced Sep 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-formatter Area - Formatter C-bug Category - Bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants