-
-
Notifications
You must be signed in to change notification settings - Fork 721
feat(minifier): remove typeof guarded global access expressions
#13751
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(minifier): remove typeof guarded global access expressions
#13751
Conversation
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR enhances the minifier to remove typeof guarded global access expressions, which are patterns commonly used to safely check if a global variable exists before accessing it. The optimization removes these redundant expressions when they don't have side effects.
- Adds early return logic for expressions without side effects in logical and conditional expression handlers
- Implements removal of
typeofpatterns liketypeof x !== 'undefined' && x - Includes comprehensive test coverage for various comparison operators with logical and conditional expressions
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Merge activity
|
CodSpeed Instrumentation Performance ReportMerging #13751 will not alter performanceComparing Summary
Footnotes |
263f051 to
a49d7cf
Compare

Remove codes like
refs #12981