Skip to content

perf(codegen): reduce branches when printing ObjectProperty and BindingProperty #13659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 11, 2025
Merged

perf(codegen): reduce branches when printing ObjectProperty and BindingProperty #13659

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 14 additions & 17 deletions crates/oxc_codegen/src/gen.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1605,19 +1605,18 @@ impl Gen for ObjectProperty<'_> {
}
}

if computed {
p.print_ascii_byte(b'[');
}
if !shorthand {
if computed {
p.print_ascii_byte(b'[');
}
self.key.print(p, ctx);
}
if computed {
p.print_ascii_byte(b']');
}
if !shorthand {
if computed {
p.print_ascii_byte(b']');
}
p.print_colon();
p.print_soft_space();
}

self.value.print_expr(p, Precedence::Comma, Context::empty());
}
}
Expand Down Expand Up @@ -2800,10 +2799,6 @@ impl Gen for ObjectPattern<'_> {

impl Gen for BindingProperty<'_> {
fn r#gen(&self, p: &mut Codegen, ctx: Context) {
if self.computed {
p.print_ascii_byte(b'[');
}

let mut shorthand = false;
if let PropertyKey::StaticIdentifier(key) = &self.key {
match &self.value.kind {
Expand All @@ -2826,15 +2821,17 @@ impl Gen for BindingProperty<'_> {
}

if !shorthand {
if self.computed {
p.print_ascii_byte(b'[');
}
self.key.print(p, ctx);
}
if self.computed {
p.print_ascii_byte(b']');
}
if !shorthand {
if self.computed {
p.print_ascii_byte(b']');
}
p.print_colon();
p.print_soft_space();
}

self.value.print(p, ctx);
}
}
Expand Down
Loading