-
-
Notifications
You must be signed in to change notification settings - Fork 726
refactor(transformer/styled-components): clarify whitespace removal logic in CSS minification #13375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
graphite-app
merged 1 commit into
main
from
08-29-refactor_transformer_styled-components_clarify_whitespace_removal_logic_in_css_minification
Aug 29, 2025
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 29, 2025
Member
Author
This was referenced Aug 29, 2025
Merged
CodSpeed Instrumentation Performance ReportMerging #13375 will improve performances by 4.24%Comparing Summary
Benchmarks breakdown
Footnotes |
167d41a to
90c09c4
Compare
a93004b to
138872a
Compare
Contributor
Merge activity
|
…ogic in CSS minification (#13375) Pure refactor. Replace a complicated `if` statement with a series of statements, to make the logic clearer. The behavior is unchanged. This is more verbose, but should be identical in performance, and in my opinion is easier to understand.
90c09c4 to
df38b2c
Compare
138872a to
be6677e
Compare
Base automatically changed from
08-28-fix_transformer_styled-components_remove_space_before_line_comment_in_css_minification
to
main
August 29, 2025 03:22
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-transformer
Area - Transformer / Transpiler
C-cleanup
Category - technical debt or refactoring. Solution not expected to change behavior
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.

Pure refactor. Replace a complicated
ifstatement with a series of statements, to make the logic clearer. The behavior is unchanged.This is more verbose, but should be identical in performance, and in my opinion is easier to understand.