-
-
Notifications
You must be signed in to change notification settings - Fork 721
perf(transformer/decorator): remove temporary Vec
#13218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf(transformer/decorator): remove temporary Vec
#13218
Conversation
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR optimizes memory allocation in the decorator transformation by eliminating an unnecessary temporary Vec creation. Instead of creating a vector and then immediately consuming it with extend(), the decorators are now directly extended into the target collection.
- Removes intermediate
Vecallocation for metadata decorators - Directly extends decorators into the method's decorator collection
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
CodSpeed Instrumentation Performance ReportMerging #13218 will not alter performanceComparing Summary
Footnotes |
Merge activity
|
12ca898 to
ef3c23a
Compare

Small perf optimization. There's no need to create a
Vechere when it's consumed immediately after.