Skip to content

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Aug 19, 2025

Small perf optimization. There's no need to create a Vec here when it's consumed immediately after.

@github-actions github-actions bot added A-transformer Area - Transformer / Transpiler C-performance Category - Solution not expected to change functional behavior, only performance labels Aug 19, 2025
Copy link
Member Author

overlookmotel commented Aug 19, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@overlookmotel overlookmotel marked this pull request as ready for review August 19, 2025 16:33
Copilot AI review requested due to automatic review settings August 19, 2025 16:33
@overlookmotel overlookmotel requested a review from Dunqing as a code owner August 19, 2025 16:33
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR optimizes memory allocation in the decorator transformation by eliminating an unnecessary temporary Vec creation. Instead of creating a vector and then immediately consuming it with extend(), the decorators are now directly extended into the target collection.

  • Removes intermediate Vec allocation for metadata decorators
  • Directly extends decorators into the method's decorator collection

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@codspeed-hq
Copy link

codspeed-hq bot commented Aug 19, 2025

CodSpeed Instrumentation Performance Report

Merging #13218 will not alter performance

Comparing 08-19-perf_transformer_decorator_remove_temporary_vec_ (ef3c23a) with main (93eaf5f)1

Summary

✅ 34 untouched benchmarks

Footnotes

  1. No successful run was found on main (ef3c23a) during the generation of this report, so 93eaf5f was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@graphite-app graphite-app bot added the 0-merge Merge with Graphite Merge Queue label Aug 20, 2025
@graphite-app
Copy link
Contributor

graphite-app bot commented Aug 20, 2025

Merge activity

Small perf optimization. There's no need to create a `Vec` here when it's consumed immediately after.
@graphite-app graphite-app bot force-pushed the 08-19-perf_transformer_decorator_remove_temporary_vec_ branch from 12ca898 to ef3c23a Compare August 20, 2025 01:16
@graphite-app graphite-app bot merged commit ef3c23a into main Aug 20, 2025
24 checks passed
@graphite-app graphite-app bot deleted the 08-19-perf_transformer_decorator_remove_temporary_vec_ branch August 20, 2025 01:21
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Aug 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-transformer Area - Transformer / Transpiler C-performance Category - Solution not expected to change functional behavior, only performance

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants