refactor(napi/oxlint2): fix lint errors #13184
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
C-cleanup
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes linting errors flagged by Oxlint in the napi/oxlint2 directory as part of enabling Oxlint across the entire repository. The changes address various TypeScript ESLint rule violations and improve type safety.
- Added oxlint disable comments to suppress specific rule violations
- Updated type definitions to be more specific and meaningful
- Fixed JSDoc documentation format issues
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| napi/oxlint2/test/compile-visitor.test.ts | Added oxlint disable comments and updated test node objects to have proper AST node structure |
| napi/oxlint2/src-js/visitor.ts | Added oxlint disable comment for no-implied-eval rule around Function constructor usage |
| napi/oxlint2/src-js/utils.ts | Added oxlint disable comment for unused parameter in assertion function |
| napi/oxlint2/src-js/types.ts | Changed Node type from generic Object to structured AST node with required properties |
| napi/oxlint2/src-js/index.ts | Fixed JSDoc tag from @constructor to @class |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
overlookmotel
force-pushed
the
08-18-refactor_napi_oxlint2_fix_lint_errors
branch
from
b988d03 to
2f7091f
Compare
graphite-app bot
pushed a commit
that referenced
this pull request
Aug 18, 2025
Same as #13184. #13173 enabled Oxlint for all the repo, but we currently skip `napi` directory. Fix all errors that Oxlint flags in `napi/parser`. We currently can't turn on Oxlint for the directory, because `oxlint-disable` comments don't work for type-aware rules, but we should be able to once that's fixed.
Member
Author
|
Cam already reviewed, and I've addressed his feedback, so merging. |
Member
Author
Merge activity
|
#13173 enabled Oxlint for all the repo, but we currently skip `napi` directory. Fix all errors that Oxlint flags in `napi/oxlint2`. We currently can't turn on Oxlint for the directory, because `oxlint-disable` comments don't work for type-aware rules, but we should be able to once that's fixed.
graphite-app
bot
force-pushed
the
08-18-refactor_napi_oxlint2_fix_lint_errors
branch
from
2f7091f to
c26d303
Compare
graphite-app
bot
deleted the
08-18-refactor_napi_oxlint2_fix_lint_errors
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#13173 enabled Oxlint for all the repo, but we currently skip
napidirectory.Fix all errors that Oxlint flags in
napi/oxlint2.We currently can't turn on Oxlint for the directory, because
oxlint-disablecomments don't work for type-aware rules, but we should be able to once that's fixed.