Skip to content

Conversation

@Boshen
Copy link
Member

@Boshen Boshen commented Aug 18, 2025

No description provided.

Copilot AI review requested due to automatic review settings August 18, 2025 08:28
@github-actions github-actions bot added the A-codegen Area - Code Generation label Aug 18, 2025
Copy link
Member Author

Boshen commented Aug 18, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added the C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior label Aug 18, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors sourcemap visualization code by consolidating functionality from a standalone example into the main codegen example and updating the API to use more descriptive method names.

  • Removed the dedicated sourcemap.rs example file
  • Updated the codegen.rs example to include sourcemap visualization capabilities
  • Changed method name from into_visualizer_text() to get_text() for better clarity

Reviewed Changes

Copilot reviewed 4 out of 5 changed files in this pull request and generated no comments.

File Description
crates/oxc_transformer_plugins/tests/integrations/replace_global_defines.rs Updated method call to use the new get_text() API
crates/oxc_codegen/examples/sourcemap.rs Removed entire file as functionality was consolidated
crates/oxc_codegen/examples/codegen.rs Added sourcemap support with visualization using the new API
crates/oxc_codegen/Cargo.toml Removed unused base64 dependency

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@graphite-app
Copy link
Contributor

graphite-app bot commented Aug 18, 2025

Merge activity

@codspeed-hq
Copy link

codspeed-hq bot commented Aug 18, 2025

CodSpeed Instrumentation Performance Report

Merging #13177 will not alter performance

Comparing 08-18-fix_codegen_improve_sourcemapings (3548cf4) with main (87dec82)1

Summary

✅ 34 untouched benchmarks

Footnotes

  1. No successful run was found on main (3548cf4) during the generation of this report, so 87dec82 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@graphite-app graphite-app bot force-pushed the 08-18-fix_codegen_improve_sourcemapings branch from aee0b57 to 3548cf4 Compare August 18, 2025 08:33
@graphite-app graphite-app bot merged commit 3548cf4 into main Aug 18, 2025
25 checks passed
@graphite-app graphite-app bot deleted the 08-18-fix_codegen_improve_sourcemapings branch August 18, 2025 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-codegen Area - Code Generation C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants