Skip to content

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Aug 15, 2025

MessageCloner (introduced in #13032) is only used when language_server feature is enabled, or in tests. Feature-gate this code, to avoid "dead code" warnings when compiling napi/oxlint2.

@github-actions github-actions bot added A-linter Area - Linter C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Aug 15, 2025
Copy link
Member Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@overlookmotel overlookmotel marked this pull request as ready for review August 15, 2025 23:37
Copilot AI review requested due to automatic review settings August 15, 2025 23:37
@overlookmotel overlookmotel requested a review from camc314 as a code owner August 15, 2025 23:37
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR addresses dead code warnings by feature-gating the MessageCloner code that is only used when the language_server feature is enabled or in tests.

  • Added conditional compilation attributes to prevent dead code warnings in napi/oxlint2 builds
  • Applied feature gates to both the message_cloner module and its import

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@overlookmotel
Copy link
Member Author

Fixes a mistake I made, and uncontroversial, so merging without review.

@overlookmotel overlookmotel added the 0-merge Merge with Graphite Merge Queue label Aug 15, 2025
Copy link
Member Author

overlookmotel commented Aug 15, 2025

Merge activity

#13132)

`MessageCloner` (introduced in #13032) is only used when `language_server` feature is enabled, or in tests. Feature-gate this code, to avoid "dead code" warnings when compiling `napi/oxlint2`.
@graphite-app graphite-app bot force-pushed the 08-16-refactor_linter_fix_dead_code_warnings_when_compiling_napi_oxlint2_ branch from 6782dc1 to 0dd7908 Compare August 15, 2025 23:39
@codspeed-hq
Copy link

codspeed-hq bot commented Aug 15, 2025

CodSpeed Instrumentation Performance Report

Merging #13132 will not alter performance

Comparing 08-16-refactor_linter_fix_dead_code_warnings_when_compiling_napi_oxlint2_ (0dd7908) with main (f0a517f)1

Summary

✅ 34 untouched benchmarks

Footnotes

  1. No successful run was found on main (0dd7908) during the generation of this report, so f0a517f was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@graphite-app graphite-app bot merged commit 0dd7908 into main Aug 15, 2025
25 checks passed
@graphite-app graphite-app bot deleted the 08-16-refactor_linter_fix_dead_code_warnings_when_compiling_napi_oxlint2_ branch August 15, 2025 23:42
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Aug 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-linter Area - Linter C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants