-
-
Notifications
You must be signed in to change notification settings - Fork 723
refactor(linter): fix dead code warnings when compiling napi/oxlint2
#13132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(linter): fix dead code warnings when compiling napi/oxlint2
#13132
Conversation
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR addresses dead code warnings by feature-gating the MessageCloner code that is only used when the language_server feature is enabled or in tests.
- Added conditional compilation attributes to prevent dead code warnings in
napi/oxlint2builds - Applied feature gates to both the
message_clonermodule and its import
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
Fixes a mistake I made, and uncontroversial, so merging without review. |
Merge activity
|
6782dc1 to
0dd7908
Compare
CodSpeed Instrumentation Performance ReportMerging #13132 will not alter performanceComparing Summary
Footnotes |

MessageCloner(introduced in #13032) is only used whenlanguage_serverfeature is enabled, or in tests. Feature-gate this code, to avoid "dead code" warnings when compilingnapi/oxlint2.