-
-
Notifications
You must be signed in to change notification settings - Fork 722
refactor(allocator): rename vars and comments in AllocatorPool
#13129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(allocator): rename vars and comments in AllocatorPool
#13129
Conversation
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This refactor improves the clarity of the AllocatorPool::new method by renaming the parameter from size to thread_count and updating comments to better describe the purpose of the pool in a multi-threaded context.
- Renamed the
sizeparameter tothread_countin both pool implementations - Updated method documentation to clarify the thread-based usage pattern
- Enhanced comments with additional context about memory optimization strategies
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| crates/oxc_allocator/src/pool_fixed_size.rs | Renamed parameter and improved comments for the fixed-size pool implementation |
| crates/oxc_allocator/src/pool.rs | Renamed parameter and updated documentation for the standard pool implementation |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
Pure refactor, and minor change, so merging without review. |
Merge activity
|
c777514 to
51f6c84
Compare
CodSpeed Instrumentation Performance ReportMerging #13129 will not alter performanceComparing Summary
|

Pure refactor. Rename
AllocatorPool::new'ssizeparam tothread_count, which is more descriptive. Improve comments for this method.