Skip to content

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Aug 15, 2025

Pure refactor. Rename AllocatorPool::new's size param to thread_count, which is more descriptive. Improve comments for this method.

Copy link
Member Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added the C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior label Aug 15, 2025
@overlookmotel overlookmotel marked this pull request as ready for review August 15, 2025 18:05
Copilot AI review requested due to automatic review settings August 15, 2025 18:05
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This refactor improves the clarity of the AllocatorPool::new method by renaming the parameter from size to thread_count and updating comments to better describe the purpose of the pool in a multi-threaded context.

  • Renamed the size parameter to thread_count in both pool implementations
  • Updated method documentation to clarify the thread-based usage pattern
  • Enhanced comments with additional context about memory optimization strategies

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
crates/oxc_allocator/src/pool_fixed_size.rs Renamed parameter and improved comments for the fixed-size pool implementation
crates/oxc_allocator/src/pool.rs Renamed parameter and updated documentation for the standard pool implementation

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@overlookmotel
Copy link
Member Author

Pure refactor, and minor change, so merging without review.

@overlookmotel overlookmotel added the 0-merge Merge with Graphite Merge Queue label Aug 15, 2025
Copy link
Member Author

overlookmotel commented Aug 15, 2025

Merge activity

)

Pure refactor. Rename `AllocatorPool::new`'s `size` param to `thread_count`, which is more descriptive. Improve comments for this method.
@graphite-app graphite-app bot force-pushed the 08-15-refactor_allocator_rename_vars_and_comments_in_allocatorpool_ branch from c777514 to 51f6c84 Compare August 15, 2025 18:08
@codspeed-hq
Copy link

codspeed-hq bot commented Aug 15, 2025

CodSpeed Instrumentation Performance Report

Merging #13129 will not alter performance

Comparing 08-15-refactor_allocator_rename_vars_and_comments_in_allocatorpool_ (51f6c84) with main (152f1f9)

Summary

✅ 34 untouched benchmarks

@graphite-app graphite-app bot merged commit 51f6c84 into main Aug 15, 2025
27 checks passed
@graphite-app graphite-app bot deleted the 08-15-refactor_allocator_rename_vars_and_comments_in_allocatorpool_ branch August 15, 2025 18:14
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Aug 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants