-
-
Notifications
You must be signed in to change notification settings - Fork 722
refactor(allocator): remove Default impl for AllocatorPool
#13128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(allocator): remove Default impl for AllocatorPool
#13128
Conversation
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR removes the Default trait implementation from AllocatorPool structs as it's no longer used after PR #13106. The change ensures that allocator pools must be explicitly constructed rather than created via default values.
- Removed
#[derive(Default)]fromAllocatorPoolin two allocator pool implementations
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| crates/oxc_allocator/src/pool_fixed_size.rs | Removed Default derive from AllocatorPool struct |
| crates/oxc_allocator/src/pool.rs | Removed Default derive from AllocatorPool struct |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
Small change, removing dead code, so merging without review. |
Merge activity
|
CodSpeed Instrumentation Performance ReportMerging #13128 will improve performances by 3.03%Comparing Summary
Benchmarks breakdown
Footnotes |
Since #13106, `Default` is not used, and it shouldn't be. Remove it.
3f3d5f5 to
152f1f9
Compare

Since #13106,
Defaultis not used, and it shouldn't be. Remove it.