Skip to content

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Aug 15, 2025

Since #13106, Default is not used, and it shouldn't be. Remove it.

@github-actions github-actions bot added the C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior label Aug 15, 2025
Copy link
Member Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@overlookmotel overlookmotel marked this pull request as ready for review August 15, 2025 17:48
Copilot AI review requested due to automatic review settings August 15, 2025 17:48
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes the Default trait implementation from AllocatorPool structs as it's no longer used after PR #13106. The change ensures that allocator pools must be explicitly constructed rather than created via default values.

  • Removed #[derive(Default)] from AllocatorPool in two allocator pool implementations

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
crates/oxc_allocator/src/pool_fixed_size.rs Removed Default derive from AllocatorPool struct
crates/oxc_allocator/src/pool.rs Removed Default derive from AllocatorPool struct

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@overlookmotel
Copy link
Member Author

Small change, removing dead code, so merging without review.

@overlookmotel overlookmotel added the 0-merge Merge with Graphite Merge Queue label Aug 15, 2025
Copy link
Member Author

overlookmotel commented Aug 15, 2025

Merge activity

@codspeed-hq
Copy link

codspeed-hq bot commented Aug 15, 2025

CodSpeed Instrumentation Performance Report

Merging #13128 will improve performances by 3.03%

Comparing 08-15-refactor_allocator_remove_default_impl_for_allocatorpool_ (152f1f9) with main (9f924f6)1

Summary

⚡ 1 improvements
✅ 33 untouched benchmarks

Benchmarks breakdown

Benchmark BASE HEAD Change
minifier[cal.com.tsx] 30.8 ms 29.9 ms +3.03%

Footnotes

  1. No successful run was found on main (5af9cc7) during the generation of this report, so 9f924f6 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

Since #13106, `Default` is not used, and it shouldn't be. Remove it.
@graphite-app graphite-app bot force-pushed the 08-15-refactor_allocator_remove_default_impl_for_allocatorpool_ branch from 3f3d5f5 to 152f1f9 Compare August 15, 2025 17:53
@graphite-app graphite-app bot merged commit 152f1f9 into main Aug 15, 2025
27 checks passed
@graphite-app graphite-app bot deleted the 08-15-refactor_allocator_remove_default_impl_for_allocatorpool_ branch August 15, 2025 17:59
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Aug 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants