Skip to content

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Aug 14, 2025

Comment describing layout of Token was out of date. Update it to correctly reflect reality.

@github-actions github-actions bot added A-parser Area - Parser C-docs Category - Documentation. Related to user-facing or internal documentation labels Aug 14, 2025
Copy link
Member Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@overlookmotel overlookmotel marked this pull request as ready for review August 14, 2025 20:45
Copilot AI review requested due to automatic review settings August 14, 2025 20:45
@overlookmotel
Copy link
Member Author

Only alters a comment, so skipping review.

@overlookmotel overlookmotel added the 0-merge Merge with Graphite Merge Queue label Aug 14, 2025
Copy link
Member Author

overlookmotel commented Aug 14, 2025

Merge activity

  • Aug 14, 8:46 PM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Aug 14, 8:46 PM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Aug 14, 9:16 PM UTC: overlookmotel added this pull request to the Graphite merge queue.
  • Aug 14, 9:22 PM UTC: Merged by the Graphite merge queue.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Updates documentation comments to accurately reflect the current bit layout of the Token struct. The comment was outdated and didn't match the actual implementation.

  • Updated bit field descriptions to include type information and correct bit ranges
  • Added documentation for unused bits (104-127)
  • Corrected bit allocation for boolean fields from 1 bit to 8 bits each

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@codspeed-hq
Copy link

codspeed-hq bot commented Aug 14, 2025

CodSpeed Instrumentation Performance Report

Merging #13103 will not alter performance

Comparing 08-14-docs_lexer_update_comment_to_match_code (56ae824) with main (7b86340)

Summary

✅ 34 untouched benchmarks

Comment describing layout of `Token` was out of date. Update it to correctly reflect reality.
@graphite-app graphite-app bot force-pushed the 08-14-docs_lexer_update_comment_to_match_code branch from 4a5d9aa to 56ae824 Compare August 14, 2025 21:17
@graphite-app graphite-app bot merged commit 56ae824 into main Aug 14, 2025
27 checks passed
@graphite-app graphite-app bot deleted the 08-14-docs_lexer_update_comment_to_match_code branch August 14, 2025 21:22
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Aug 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-parser Area - Parser C-docs Category - Documentation. Related to user-facing or internal documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants